Add OSS licensing to project#14
Open
complexspaces wants to merge 1 commit intomasterfrom
Open
Conversation
jpgoldberg
suggested changes
Aug 8, 2024
Contributor
jpgoldberg
left a comment
jpgoldberg
left a comment
There was a problem hiding this comment.
I had not anticipated that I would request a change, but see my comment about the copyright date.
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2024 1Password | |||
Contributor
There was a problem hiding this comment.
I'm not sure about this, but I think the copyright data should include 2018 as well as 2024. Even if the licensing is new, the copyright should include the creation and modification datas.
Author
There was a problem hiding this comment.
I don't have any objections. Something like this then?
Suggested change
| Copyright (c) 2024 1Password | |
| Copyright (c) 2018, 2024 1Password |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1Password is moving this repository into the OSS domain to allow for others to use resources in it more freely. See #13 for confirmation of copyright eligibility, etc.
This PR also implements a new CLA, ensuring that all contributions going forward have a clear licensing state.
Closes #13