ci: adopt org Node baseline (lint+typecheck+test+build) + secret-scan#4
Merged
Conversation
…alues - pnpm-lock.yaml resynced (ERR_PNPM_OUTDATED_LOCKFILE vs airiscode-core). - .gitleaks.toml allowlists the upstream Gemini/Qwen public OAuth client secret (installed-app credential, not confidential) + a sanitizer test fixture. - caller keeps the turbo-scoped gate (run-command) until the dormant Layer 2 packages are removed; full baseline deferred. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Every workspace package shipped a "lint": "eslint ..." script, but eslint was never installed anywhere in this fork (no devDependency, absent from the lockfile) and the leftover root .eslintrc.json never actually ran. The org standard linter is Biome, so adopt it to match the agiletec repo. - Add @biomejs/biome to root devDependencies (no pnpm catalog here, pinned). - Add biome.json replicating agiletec's curated ruleset (recommended:false + error-level rules), formatter, and vcs blocks. - Replace "eslint ..." with "biome check ." in all 20 package lint scripts (packages/gemini-core left as its echo no-op, per design). - Remove the orphaned .eslintrc.json. - Apply `biome check --write` (formatting + safe fixes) and fix the residual real violations: unused catch bindings, escape/shadowed-global renames, redundant test non-null assertions, a placeholder async generator, and a generic-T cast where biome's Object.hasOwn safe-fix outran tsc. Rules tuned for inherited Qwen-fork code (for reviewers): - noControlCharactersInRegex: off — terminal/ANSI handling intentionally matches control chars (every hit carried an eslint-disable no-control-regex). - noUndeclaredVariables: off — redundant with tsc and misfires on TS type references; mirrors agiletec's TypeScript override. - noExplicitAny / noEmptyBlockStatements: warn — too noisy to gate on now across the fork; kept visible as warnings for later cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt the org opinionated baseline reusable. Logic in agiletec-inc/.github. Required checks:
secret-scan / scan,ci / ci.