Remove FontAwesome and Hero icons from plenum and bundle#108
Merged
DerekAgility merged 1 commit intomainfrom Mar 17, 2026
Merged
Remove FontAwesome and Hero icons from plenum and bundle#108DerekAgility merged 1 commit intomainfrom
DerekAgility merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DerekAgility
commented
Mar 16, 2026
| IconTrash, | ||
| IconTrashFilled, | ||
| IconUpload, | ||
| IconX, |
Contributor
Author
There was a problem hiding this comment.
Going forward, if any component requires another TablerIcon, we will need to import it here
DerekAgility
commented
Mar 16, 2026
| IconTrash, | ||
| IconTrashFilled, | ||
| IconUpload, | ||
| IconX, |
Contributor
Author
There was a problem hiding this comment.
And then add to the epxort list here
jules-exel
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of reducing the main manager-app bundle size.
In plenum, we are removing the packages for Font Awesome icons (the only usage of it was in one of the stories) and Hero Icon (not even used). This will decrease the bundled package for plenum.
To decrease it just a little bit more, I have removed the import for the entire package of TablerIcons and only import those that we need.