add one more method to be the same standard as httpclient so it can r…#8
Open
ratchapol-an wants to merge 2 commits intomasterfrom
Open
add one more method to be the same standard as httpclient so it can r…#8ratchapol-an wants to merge 2 commits intomasterfrom
ratchapol-an wants to merge 2 commits intomasterfrom
Conversation
pH200
requested changes
Dec 17, 2019
| { | ||
| return await SendAsync(request.RequestUri.PathAndQuery, (url) => | ||
| { | ||
| request.RequestUri = new Uri(url); |
Collaborator
There was a problem hiding this comment.
Good trick for replacing URL, but it does not look straightforward. Please add unit test for that.
Additionally, please put this method into #if !NET462 block. HttpRequestMessage cannot be reused for netframework.
| foreach (var ex in Exceptions) | ||
| { | ||
| sb.Append(string.Format("\r\n - \"{0}\" -> {1}", ex.Uri, ex.Message)); | ||
| sb.Append(string.Format("\r\n - \"{0}\" -> {1}", ex.Message, ex.Uri)); |
Collaborator
There was a problem hiding this comment.
I am not sure why you want to change this part, as it's mostly for backward compatibility (old internal component).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add one more method to be the same standard as httpclient so it can reuse more.