CNCF: update footers / logo / copyrights#4470
Conversation
|
/gcbrun |
|
/gcbrun does the CI still work? |
|
/gcbrun |
|
/gcbrun(5d45dd9) |
|
eyyy! We have a build! I can updated the checks to use the new status. |
|
Build Failed 😭 Build Id: 76038bc6-e975-44de-9827-10e9eb11965f Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
That's a legit failure - grpc client would need to be regen'd 🤔 I don't know if we need to have Google + CNCF in the Apache header for old files? @lacroixthomas we may need to look at prior art, unless there is something in the onboarding, not sure. |
|
From what I've seen, I don't think it's required to update old files, will double check that, but that's why I added on the templates only (forgot that it needs to re-generate the other ones), hmm |
|
From what I understood, it's only for the website that needs the copyrights etc, on the code files (old and new), we can keep them as they are or add both Google + CNCF or just Agones I can split this one to only contains the website and another one for code if needed, to be able to tick the website part from the list ? @markmandel |
Yeah - let's do that, and then we can work out what the appropriate path is for licencing files (we'll have to work that out anyway). |
|
Build Failed 😭 Build Id: 616eecec-0659-48c2-822e-280f53330239 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Got an error on the
|
|
Build Failed 😭 Build Id: ea6dad18-85b7-414c-9edf-d090cab28c94 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Looks like a flake: /gcbrun |
|
Build Failed 😭 Build Id: 489ffe0d-d5c4-45ca-b481-61d21748799f Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
From Gonna check, that rings a bell, might have already seen this error |
|
Build Failed 😭 Build Id: 580c8abb-30a8-4776-b1a0-ccefaf3bdc25 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
The previous agones release was in an invalid state, the check to uninstall it was not triggered (state not catched), I updated it ( b5bc5ad ) and now got: |
|
Nice fix! |
|
Build Succeeded 🥳 Build Id: e20e1126-9872-4b54-a0fb-e2969487108f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Finally ! 😄 |
markmandel
left a comment
There was a problem hiding this comment.
Looks good - but needs some tweaks!
site/content/en/_index.html
Outdated
| {{< blocks/section color="light" type="row">}} | ||
| <div class="col text-center"> | ||
| <p class="lead mt-4">We are a <strong>Cloud Native Computing Foundation</strong> | ||
| incubating project.</p> |
There was a problem hiding this comment.
| incubating project.</p> | |
| sandbox project.</p> |
We're a sandbox project - cncf/sandbox#469 😄
site/content/en/_index.html
Outdated
| <a href="http://supersolid.com/" data-proofer-ignore><img alt="supersolid" width="100" class="mb-4" src="images/supersolid.png" /></a> | ||
| <a href="http://www.yager.de/"><img alt="yager" width="100" class="mb-4" src="images/yagerdevelopment.png" /></a> | ||
| <a href="http://mcmahan.games/"><img alt="mcmahan.games" width="100" class="mb-4" src="images/mcmahangames.png" /></a> | ||
| <a href="http://accelbyte.io/"><img alt="accelbyte" width="100" class="mb-4" src="images/accelbyte.png" /></a> |
There was a problem hiding this comment.
There should be no links or forms for capturing enterprise support leads. Instead, it is fine to have an enterprise support, commercial partners or similar page. Companies must be listed on that page in alphabetical order, or the order can be changed randomly on each page load.
This isn't enterprise support leads - so this should be left alone -- those that get on the website first get top position 👍🏻
README.md
Outdated
| ## Licence | ||
|
|
||
| Apache 2.0 | ||
|
|
There was a problem hiding this comment.
If the project does not have a website, this copyright notice must be added in the README or similar location.
We don't need this either.
|
Build Failed 😭 Build Id: bde5b6e9-45f5-459a-aa5f-8002fe774867 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
oh no, autopilot again - gke-autopilot-1.34 |
|
/gcbrun |
|
Build Failed 😭 Build Id: 211cfd2b-4862-4972-b7d3-cb5462c36867 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Omg. |
|
Interestingly, the TCP connections are working again, so 🤷🏻 |
|
/gcbrun |
|
Build Failed 😭 Build Id: c43e3c5a-d29b-43fb-8548-65e1a52af79d Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
I resolved the conflicts on GitHub - let's see how it looks. |
site/config.toml
Outdated
| @@ -73,7 +73,7 @@ description = "Agones is a library for hosting, running and scaling dedicated ga | |||
|
|
|||
| [params] | |||
| copyright = "Copyright Google LLC All Rights Reserved." | |||
There was a problem hiding this comment.
Gah, I messed up the copyright when resolving conflicts. Sorry @lacroixthomas !
|
Build Succeeded 🥳 Build Id: 25cdcdff-939b-43bd-adb5-627178aad072 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: 2c7c28cd-6c77-4861-9136-f188e72c7837 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Based on these guidelines: https://github.com/cncf/foundation/blob/main/policies-guidance/website-guidelines.md
Updated copyright to "Agones a Series of LF Projects, LLC" in config, README, and boilerplate templates
Added CNCF compliant footer with policy link
Added CNCF acknowledgment section and logo to homepage
Alphabetized companies list
Added dark/light theme support for CNCF section
Which issue(s) this PR fixes:
Part of #4421
Special notes for your reviewer:
Did not update all the copyrights from every files, I was checking https://github.com/devfile/api which is on CNCF as well and they did not update it either, I guess it's alright ? I updated the templates though