Open
Conversation
Newer gcc's warn/error on the implicit fallthough. Add a break to make the intent clear.
hartzell
pushed a commit
to hartzell/spack
that referenced
this pull request
Dec 31, 2018
There's a missing break in a switch statement that newer gcc's dislike. Our spack#4696 simply disallowed newer gcc's. This fixes the problem instead. It's been [PR'ed upstream](agordon/fastx_toolkit#22). Tested with gcc@5.5.0 and gcc@8.2.0 on CentOS.
adamjstewart
pushed a commit
to spack/spack
that referenced
this pull request
Dec 31, 2018
There's a missing break in a switch statement that newer gcc's dislike. Our #4696 simply disallowed newer gcc's. This fixes the problem instead. It's been [PR'ed upstream](agordon/fastx_toolkit#22). Tested with gcc@5.5.0 and gcc@8.2.0 on CentOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer gcc's warn/error on the implicit fallthough.
Add a break to make the intent clear.
This was also mentioned in #14.