Fix RecursionError for duplicate files#133
Open
dvdl16 wants to merge 3 commits into
Open
Conversation
`associate_files()` is called from `validate`, and for Files sharing a `content_hash` it calls `.save()` on the existing duplicate row. That save re-enters `validate` -> `associate_files`, which saves back into the original file, producing an endless A->B->A loop (maximum recursion depth exceeded). - Guard `associate_files()` in `validate` with a new `associating_files` flag so a save triggered from within association does not re-run association. - Set `existing_file.flags.associating_files = True` before saving the duplicate so the recursion is broken. - Skip appending a `file_association` row that already links the same doctype/name, avoiding duplicate child rows on repeated associations.
Author
|
@agritheory Thank you for this app! As I'm not a collaborator, I don't think the failing actions have access to the necessary env vars. Let me know how you'd like me to proceed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132
associate_files()behind a flag so a save triggered from within association does not re-run association:associate_files():file_associationchild rows - only append the association if the samelink_doctype/link_nameisn't already present:This breaks the recursion while still performing the intended one-pass association, and prevents redundant association rows from accumulating.