feat: adjust Farm COA inv adj and account types - #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #145
Adjusts the name of the account type "Stock Adjustment" account from "Inventory Adjustment" to "Inventory Write Off" as proposed in the issue. Since Test Utils owns this COA (vs modifying one from ERPNext), I did the change directly in the JSON.
I also went through all the Company doc's Account link fields (plus HRMS ones) and made sure the Farm COA had an account with the account type that the field's filter is looking for - only had to add an account type to the Employee Advances to conform with ERPNext's standard with Numbers.
There were two account type filters that are not covered in Farm COA, but they also are not in ERPNext's Standard with Numbers - I can add account with these account types if needed: