Skip to content

Better relationship naming#453

Merged
sheinbergon merged 12 commits intoagronholm:masterfrom
sheinbergon:better-field-name-for-relationships
Feb 3, 2026
Merged

Better relationship naming#453
sheinbergon merged 12 commits intoagronholm:masterfrom
sheinbergon:better-field-name-for-relationships

Conversation

@sheinbergon
Copy link
Collaborator

Changes

Fixes #377

Uses FK name for relationship names

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) which would fail without your patch
  • [] You've added a new changelog entry (in CHANGES.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

- Fix big bad boo-boo in task groups
  (`#123 <https://github.com/agronholm/sqlacodegen/issues/123>`_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@sheinbergon sheinbergon force-pushed the better-field-name-for-relationships branch from 3820ad4 to 65e8f31 Compare January 23, 2026 13:51
@coveralls
Copy link

coveralls commented Jan 23, 2026

Coverage Status

coverage: 97.513% (+0.05%) from 97.459%
when pulling 76905c6 on sheinbergon:better-field-name-for-relationships
into b97ce66 on agronholm:master.

@sheinbergon sheinbergon force-pushed the better-field-name-for-relationships branch from 06a6678 to 4ad39ff Compare January 23, 2026 22:34
@sheinbergon sheinbergon requested a review from agronholm January 24, 2026 12:08
@agronholm
Copy link
Owner

I'll try to get this reviewed on Monday.

Updated version header and improved formatting for clarity.
Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and one trivial change.

@sheinbergon sheinbergon requested a review from agronholm January 30, 2026 17:03
@sheinbergon
Copy link
Collaborator Author

@agronholm whenever you have the time, please re-review my latest fixes

@sheinbergon sheinbergon requested a review from agronholm February 3, 2026 21:57
Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good. I didn't go through this latest change with a fine-toothed comb, but it seems like a good bunch of improvements. We'll do further changes if we find a problem with it.

@sheinbergon
Copy link
Collaborator Author

Alright, looks good. I didn't go through this latest change with a fine-toothed comb, but it seems like a good bunch of improvements. We'll do further changes if we find a problem with it.

10x. I tidied up the code a bit. There's still an issue with collissions on M2O, But that'll be for a different PR

@sheinbergon sheinbergon merged commit bdcc4b8 into agronholm:master Feb 3, 2026
8 checks passed
@sheinbergon sheinbergon deleted the better-field-name-for-relationships branch February 3, 2026 22:38
@sheinbergon sheinbergon added this to the 4.0.0rc3 milestone Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better field name for relationships (many side)

3 participants