Better relationship naming#453
Merged
sheinbergon merged 12 commits intoagronholm:masterfrom Feb 3, 2026
Merged
Conversation
3820ad4 to
65e8f31
Compare
06a6678 to
4ad39ff
Compare
Owner
|
I'll try to get this reviewed on Monday. |
Updated version header and improved formatting for clarity.
agronholm
reviewed
Jan 27, 2026
Owner
agronholm
left a comment
There was a problem hiding this comment.
One question and one trivial change.
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
Collaborator
Author
|
@agronholm whenever you have the time, please re-review my latest fixes |
agronholm
reviewed
Feb 1, 2026
agronholm
approved these changes
Feb 3, 2026
Owner
agronholm
left a comment
There was a problem hiding this comment.
Alright, looks good. I didn't go through this latest change with a fine-toothed comb, but it seems like a good bunch of improvements. We'll do further changes if we find a problem with it.
Collaborator
Author
10x. I tidied up the code a bit. There's still an issue with collissions on M2O, But that'll be for a different PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #377
Uses FK name for relationship names
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchCHANGES.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.