Added pythonFSPS functionality. Updated colors_table, killed BAND_IDS.#22
Open
meorr wants to merge 8 commits intoagurvich:mainfrom
Open
Added pythonFSPS functionality. Updated colors_table, killed BAND_IDS.#22meorr wants to merge 8 commits intoagurvich:mainfrom
meorr wants to merge 8 commits intoagurvich:mainfrom
Conversation
…and_lums_from_tables.py. Added pythonFSPS functionality, with.. literally >hundred possible filters. Also nixed the whole BAND_ID thing from star_studio.py etc.
# Conflicts: # src/firestudio/utils/stellar_utils/colors_sps/read_band_lums_from_tables.py
…lute magnitude and effective wavelength values.
…lute magnitude and effective wavelength values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated colors_table and read_band_lums_from_tables in read_band_lums_from_tables.py. Added pythonFSPS functionality, with.. literally >hundred possible filters. Also nixed the whole BAND_ID thing from star_studio.py etc.
(will separately create pull request for the fsps tables once they are ready)
uhhh hope there's no bugs?