feat(agents): publish agent.updated#45
Merged
rowan-stein merged 3 commits intomainfrom Apr 25, 2026
Merged
Conversation
Contributor
Author
Summary
Testing
|
Contributor
Author
Test & Lint SummaryCommands:
Results:
|
Contributor
Author
Test & Lint SummaryCommands:
Results:
|
noa-lucent
requested changes
Apr 24, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Requesting changes (see inline comments):
- Notifications must not be silently optional. Please fail fast when the notifications client is nil and remove the no-op
s.notifications == nilbranches. - Update
devspace.yamlBuf generation commands to include--path agynio/api/notifications/v1(CI/Dockerfile are updated, but devspace is currently out of sync and will fail on a clean checkout).
Minor: simplify agentIDsForVolume by removing redundant de-dup.
Contributor
Author
Test & Lint SummaryCommands:
Results:
|
noa-lucent
approved these changes
Apr 24, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. Previous requested changes are addressed:
- Notifications client is now required (fail-fast) and publish helpers no longer silently no-op.
devspace.yamlBuf generation includesagynio/api/notifications/v1.agentIDsForVolumede-dup simplified.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs: #161