Skip to content

feat(agents): publish agent.updated#45

Merged
rowan-stein merged 3 commits intomainfrom
noa/issue-161
Apr 25, 2026
Merged

feat(agents): publish agent.updated#45
rowan-stein merged 3 commits intomainfrom
noa/issue-161

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • publish agent.updated notifications for agent and sub-resource mutations
  • touch agent updated_at on sub-resource writes (attachments, MCPs, skills, hooks, env, init scripts)
  • add notifications service config wiring

Testing

  • go test ./...
  • go vet ./...
  • go build ./...

Refs: #161

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • publish agent.updated notifications for agent and sub-resource mutations
  • touch agent updated_at on sub-resource writes (attachments, MCPs, skills, hooks, env, init scripts, volume updates)
  • wire notifications service client/config in agents service

Testing

  • go test ./...
  • go vet ./...
  • go build ./...

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Commands:

  • go test ./...
  • go vet ./...
  • go build ./...

Results:

  • Tests: passed 1 package, failed 0, skipped 5 packages (no test files)
  • Lint: no errors
  • Build: succeeded

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Commands:

  • go test ./...
  • go vet ./...
  • go build ./...

Results:

  • Tests: passed 1 package, failed 0, skipped 5 packages (no test files)
  • Lint: no errors
  • Build: succeeded

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes (see inline comments):

  • Notifications must not be silently optional. Please fail fast when the notifications client is nil and remove the no-op s.notifications == nil branches.
  • Update devspace.yaml Buf generation commands to include --path agynio/api/notifications/v1 (CI/Dockerfile are updated, but devspace is currently out of sync and will fail on a clean checkout).

Minor: simplify agentIDsForVolume by removing redundant de-dup.

Comment thread internal/server/server.go
Comment thread internal/store/agent_helpers.go
Comment thread .github/workflows/ci.yml
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Commands:

  • go test ./...
  • go vet ./...
  • go build ./...

Results:

  • Tests: passed 1 package, failed 0, skipped 5 packages (no test files)
  • Lint: no errors
  • Build: succeeded

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review complete. Previous requested changes are addressed:

  • Notifications client is now required (fail-fast) and publish helpers no longer silently no-op.
  • devspace.yaml Buf generation includes agynio/api/notifications/v1.
  • agentIDsForVolume de-dup simplified.

LGTM.

@rowan-stein rowan-stein merged commit f1ea5a7 into main Apr 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants