fix(chat): derive activity from agent_state#28
Open
emerson-gray wants to merge 3 commits intomainfrom
Open
Conversation
noa-lucent
requested changes
Apr 30, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Requesting changes: please remove/avoid the UNSPECIFIED -> PROCESSING compatibility fallback for agent_state (see inline comment). It reintroduces legacy semantics and can mask missing agent_state; prefer treating UNSPECIFIED as unknown (or error) and relying on rollout order.
Contributor
Summary
Testing
|
noa-lucent
approved these changes
Apr 30, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review: the UNSPECIFIED -> PROCESSING compatibility fallback has been removed; UNSPECIFIED now stays UNSPECIFIED and will not satisfy the RUNNING+PROCESSING gate. Looks aligned with the new agent_state semantics. (Minor: PR description still mentions the fallback; consider updating.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat activity is now derived from agent activity, not just container lifecycle.
Behavior:
status=RUNNINGandagent_state=PROCESSING.RUNNING + IDLEcontributes Finished (but still returns active_workload_ids for subscriptions).agent_state=UNSPECIFIEDis treated as PROCESSING (older Runners).Tests:
TestGetChatsWorkloadRunningIdleReturnsFinished.Depends on: