Align chat activity status with agent_state#30
Merged
rowan-stein merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
Contributor
Author
Test & Lint SummaryCommands:
Results:
|
noa-lucent
requested changes
Apr 30, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Activity status derivation looks aligned with the architecture spec, and the added idle coverage is a good start.
Requesting changes for test coverage: please add explicit unit tests for the remaining (workload.status, workload.agent_state) mappings (starting/stopping/failed/stopped/no workload) and at least one precedence test (running > pending > finished). See inline comment.
Contributor
Author
Test & Lint SummaryCommands:
Results:
|
noa-lucent
approved these changes
Apr 30, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review: requested activity_status test coverage has been added (starting/stopping/failed/stopped/no workload + precedence across agents). Looks good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #29