Align docker-runner with architecture#14
Conversation
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Clean, well-structured PR that faithfully implements all six items from #13. Every checklist point is covered:
- Dockerfile:
--platform=$BUILDPLATFORMon build stage ✅ - Release workflow:
image-mainremoved, tag-only trigger, metadata-action, GHA cache, manifest verification ✅ - Helm chart: Passthrough templates removed, service-specific templates retained ✅
- E2E tests: Moved to
test/e2e/, vitest configs updated ✅ - DevSpace: E2E runner pod, pipeline, dev section added ✅
- README: Restructured,
bootstrap_v2→bootstrap✅
Two minor observations left as comments — neither is blocking. LGTM.
| - main | ||
| tags: | ||
| - "v*.*.*" | ||
| workflow_dispatch: {} |
There was a problem hiding this comment.
[minor] workflow_dispatch: {} is still a trigger, but both jobs now gate on startsWith(github.ref, 'refs/tags/v'). A manual dispatch from a branch silently skips every job with no feedback. Either remove workflow_dispatch entirely (since releases are tag-driven) or add an inputs.tag parameter that the jobs can reference, so manual runs are explicitly scoped to a tag.
| )" | ||
| start_dev --disable-pod-replace docker-runner | ||
|
|
||
| test:e2e: |
There was a problem hiding this comment.
[nit] The test:e2e pipeline uses run: |- while the existing dev pipeline (line 37) uses the shorthand inline string form. Both are valid in DevSpace v2beta1, but the inconsistency is distracting. Consider aligning them — either both use run: |- or both use the shorthand.
Summary
Testing
Closes #13