Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Align docker-runner with architecture#14

Merged
rowan-stein merged 1 commit intomainfrom
noa/issue-13
Mar 17, 2026
Merged

Align docker-runner with architecture#14
rowan-stein merged 1 commit intomainfrom
noa/issue-13

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • align Dockerfile and release workflow with tag-only releases and manifest checks
  • move E2E tests to test/e2e with updated Vitest configs
  • add DevSpace e2e runner pod, clean chart passthroughs, and refresh README

Testing

  • pnpm lint
  • pnpm build
  • pnpm test

Closes #13

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • pnpm lint (no errors)
  • pnpm build
  • pnpm test (7 files, 12 passed, 0 failed, 0 skipped)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-structured PR that faithfully implements all six items from #13. Every checklist point is covered:

  • Dockerfile: --platform=$BUILDPLATFORM on build stage ✅
  • Release workflow: image-main removed, tag-only trigger, metadata-action, GHA cache, manifest verification ✅
  • Helm chart: Passthrough templates removed, service-specific templates retained ✅
  • E2E tests: Moved to test/e2e/, vitest configs updated ✅
  • DevSpace: E2E runner pod, pipeline, dev section added ✅
  • README: Restructured, bootstrap_v2bootstrap

Two minor observations left as comments — neither is blocking. LGTM.

- main
tags:
- "v*.*.*"
workflow_dispatch: {}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] workflow_dispatch: {} is still a trigger, but both jobs now gate on startsWith(github.ref, 'refs/tags/v'). A manual dispatch from a branch silently skips every job with no feedback. Either remove workflow_dispatch entirely (since releases are tag-driven) or add an inputs.tag parameter that the jobs can reference, so manual runs are explicitly scoped to a tag.

Comment thread devspace.yaml
)"
start_dev --disable-pod-replace docker-runner

test:e2e:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] The test:e2e pipeline uses run: |- while the existing dev pipeline (line 37) uses the shorthand inline string form. Both are valid in DevSpace v2beta1, but the inconsistency is distracting. Consider aligning them — either both use run: |- or both use the shorthand.

@rowan-stein rowan-stein merged commit 10b27c6 into main Mar 17, 2026
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align docker-runner service with architecture documentation

3 participants