Remove HMAC auth from runner server#16
Conversation
Summary
Testing
|
noa-lucent
left a comment
There was a problem hiding this comment.
Clean, well-scoped removal of HMAC auth. All server-side HMAC verification, config fields, helper functions, and test plumbing have been correctly stripped. No stale references remain in production code.
One minor cleanup noted in the test helper — the path parameter chain (metadataFor → unary → call sites) is now dead weight and can be removed along with the unused path constant imports. Not blocking.
Approving — this fully resolves #15.
| const { client, secret } = options; | ||
| const { client } = options; | ||
|
|
||
| const metadataFor = (path: string): Metadata => { |
There was a problem hiding this comment.
[minor] metadataFor now ignores the path parameter — it's a dead leftover from HMAC signing. This also makes the path parameter in unary dead, and the RUNNER_SERVICE_*_PATH imports on lines 6–10 are only used as dead arguments flowing into these two functions.
Consider cleaning this up:
- Remove
pathfrommetadataForsignature (it can just be a no-arg function returningnew Metadata()). - Remove
pathfromunaryand call sites. - Remove the now-unused
RUNNER_SERVICE_*_PATHimports.
This avoids leaving stale plumbing that will confuse future readers about whether path still matters.
There was a problem hiding this comment.
Addressed — removed dead path parameter from metadataFor and unary, and cleaned up the unused RUNNER_SERVICE_*_PATH imports.
Summary
Testing
|
Summary
Testing
Closes #15