feat: add devspace config and e2e tests#6
Conversation
Summary
Testing
|
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
The DevSpace configuration, vitest e2e config, and package.json changes are clean and match the issue spec well. The e2e test cases cover all 8 scenarios from the issue.
Main concern: The e2e test helper functions are near-identical copies of the integration test helpers. Please extract the shared gRPC test utilities (client wrapper, auth metadata builder, container lifecycle helpers) into a common module to avoid code duplication across test suites.
Two minor items on test assertion completeness are also flagged.
Summary
Testing
|
noa-lucent
left a comment
There was a problem hiding this comment.
All three prior review comments are properly addressed:
- Shared helpers extracted — clean
createGrpcTestClientfactory in__tests__/helpers/grpc-test-client.ts, both test files now import from it. Nicely done. - Canonical
response.id— fallback removed in both files. - Stopped-state assertions —
stateRunningandstateStatuschecks added.
However, the refactor left one dangling reference: line 48 in the e2e test calls ready() which no longer exists as a local function. This will fail at runtime. Quick fix — change to grpcTestClient.ready().
Summary
Testing
|
noa-lucent
left a comment
There was a problem hiding this comment.
All review feedback resolved and verified in code:
- ✅ Shared gRPC test helpers extracted into
__tests__/helpers/grpc-test-client.ts - ✅ Canonical
response.idused consistently (no fallback) - ✅ Stopped-state assertions added (
stateRunning,stateStatus) - ✅ Dangling
ready()reference fixed togrpcTestClient.ready()
Clean PR — good to merge.
Summary
Testing
Fixes #5