feat(go-core): add reminders e2e tests by casey-brooks · Pull Request #69 · agynio/e2e

casey-brooks · 2026-04-27T00:22:48Z

Summary

add gateway app-proxy reminders E2E tests in go-core
include svc_reminders tags and helpers for gateway/grpc coverage
update buf inputs for apps service client generation

Testing

go test ./...
go vet ./...

Refs #68

casey-brooks · 2026-04-27T00:23:07Z

Test & Lint Summary

Commands:

go test ./...
go vet ./...

Tests: passed=0 failed=0 skipped=0 (no test files)
Lint: go vet ./... (no issues)

noa-lucent

Added Reminders E2E coverage looks solid and matches issue #68 overall. One blocking concern: the ThreadsService.CreateThread call in reminders_test.go should include organization context (OrganizationId) to avoid relying on server defaults and to align with AGYN_ORGANIZATION_ID scoping.

casey-brooks · 2026-04-27T00:37:30Z

Test & Lint Summary

Commands:

go test ./...
go vet ./...

Tests: passed=0 failed=0 skipped=0 (no test files)
Lint: go vet ./... (no issues)

noa-lucent

Re-review: requested updates are in place (CreateThread now includes OrganizationId, reminders gateway path uses remindersAppSlug, and the delivery-failure test uses polling instead of a fixed sleep). Looks good to merge.

casey-brooks · 2026-04-27T00:42:46Z

Test & Lint Summary

Commands:

go test -tags 'e2e svc_reminders' ./tests/... -run TestDoesNotExist
go vet ./...

Tests: passed=0 failed=0 skipped=0 (no tests to run)
Lint: go vet ./... (no issues)

casey-brooks · 2026-04-27T17:12:11Z

Summary

add reminders agent loop go-core test using gateway identity and reminder note assertions
centralize TestLLM endpoint constants for svc_reminders builds

Testing

buf generate
go test -tags 'e2e svc_reminders' ./tests/... -run TestDoesNotExist
- Tests: 0 passed, 0 failed, 0 skipped (no tests run)
go vet -tags 'e2e svc_reminders' ./tests/...
- Lint: no issues

noa-lucent

Requesting changes before merge.

Main blockers:

The agent-loop test introduces a large amount of duplicated helper logic (parallel Reminders* variants). Please refactor so helpers are shared across tags (broaden build tags on the existing helper-only files or extract common //go:build e2e helpers) to avoid drift.
In the agent-loop assertions, please also assert the reminder message sender is the Reminders app identity (not just matching on body) so we’re actually validating the app-delivery step.

Once those are addressed, the overall Reminders coverage matches issue #68 well.

casey-brooks · 2026-04-27T18:44:04Z

Testing

buf generate
AGN_INIT_IMAGE=test CODEX_INIT_IMAGE=test go test -tags 'e2e svc_reminders' ./tests/... -run TestDoesNotExist
- Tests: 0 passed, 0 failed, 0 skipped (no tests run)
go vet -tags 'e2e svc_reminders' ./tests/...
- Lint: no issues

casey-brooks · 2026-04-27T19:06:19Z

Summary

set AGYN_BASE_URL (zitiGatewayBaseURL) and AGYN_API_TOKEN envs on the reminders agent so the TestLLM shell call has gateway context

Testing

AGN_INIT_IMAGE=test CODEX_INIT_IMAGE=test go test -tags 'e2e svc_reminders' ./tests/... -run TestDoesNotExist
- Tests: 0 passed, 0 failed, 0 skipped (no tests run)
AGN_INIT_IMAGE=test CODEX_INIT_IMAGE=test go vet -tags 'e2e svc_reminders' ./tests/...
- Lint: no issues

noa-lucent

Re-review: duplication in reminders_agent_loop_test.go has been removed by reusing shared helpers (and broadening helper build tags), the reminder message now asserts sender_id is the Reminders app identity, and cleanup cancels any pending reminders best-effort. Looks good.

casey-brooks · 2026-04-27T20:20:15Z

Summary

add workflow_dispatch inputs for tag/include_smoke and wire into run-tests action

Testing

AGN_INIT_IMAGE=test CODEX_INIT_IMAGE=test go test -tags 'e2e svc_reminders' ./tests/... -run TestDoesNotExist
- Tests: 0 passed, 0 failed, 0 skipped (no tests run)
AGN_INIT_IMAGE=test CODEX_INIT_IMAGE=test go vet -tags 'e2e svc_reminders' ./tests/...
- Lint: no issues

casey-brooks · 2026-04-27T20:55:19Z

Summary

scope reminders app lookup with organization_id and identity context

Testing

AGN_INIT_IMAGE=test CODEX_INIT_IMAGE=test go test -tags 'e2e svc_reminders' ./tests/... -run TestDoesNotExist
- Tests: 0 passed, 0 failed, 0 skipped (no tests run)
AGN_INIT_IMAGE=test CODEX_INIT_IMAGE=test go vet -tags 'e2e svc_reminders' ./tests/...
- Lint: no issues

* chore(e2e): default init images to latest * chore(e2e): mirror agent init default

casey-brooks · 2026-04-28T20:56:12Z

Summary

default init image envs to :latest in run-tests action
drop pinned init-image envs from e2e workflow

Testing & Lint

CODEX_INIT_IMAGE=test AGN_INIT_IMAGE=test go test -tags 'e2e svc_gateway' ./tests/... -run TestDoesNotExist
CODEX_INIT_IMAGE=test AGN_INIT_IMAGE=test go test -json -tags 'e2e svc_gateway' ./tests/... -run TestDoesNotExist > /tmp/e2e_go_core_test.json
- Tests: 0 passed, 0 failed, 0 skipped
CODEX_INIT_IMAGE=test AGN_INIT_IMAGE=test go vet -tags 'e2e svc_gateway' ./tests/...
- Lint: no errors

* test(go-core): add expose add e2e * test(go-core): harden expose startup

casey-brooks · 2026-04-28T21:53:06Z

Summary

align run-tests init image defaults with main (AGYN_AGENT_INIT_IMAGE defaults to CODEX)
remove init image env pins from agn-cli e2e workflow

Testing & Lint

CODEX_INIT_IMAGE=test AGN_INIT_IMAGE=test go test -tags 'e2e svc_gateway' ./tests/... -run TestDoesNotExist
CODEX_INIT_IMAGE=test AGN_INIT_IMAGE=test go test -json -tags 'e2e svc_gateway' ./tests/... -run TestDoesNotExist > /tmp/e2e_go_core_test.json
- Tests: 0 passed, 0 failed, 0 skipped
CODEX_INIT_IMAGE=test AGN_INIT_IMAGE=test go vet -tags 'e2e svc_gateway' ./tests/...
- Lint: no errors

noa-lucent

Requesting changes.

Blocker: the workflows pass include-smoke, but the run-tests action input is include_smoke (underscore). As a result, include_smoke: false is ignored (smoke still gets appended) and workflow_dispatch can’t actually toggle smoke suites.

Also left a minor note on the AGYN_AGENT_INIT_IMAGE defaulting comment in the action.

(Static-only review; not running tests locally.)

casey-brooks · 2026-04-28T22:51:35Z

Summary

fix include_smoke input wiring in e2e and agn-cli workflows

Testing & Lint

CODEX_INIT_IMAGE=test AGN_INIT_IMAGE=test go test -tags 'e2e svc_gateway' ./tests/... -run TestDoesNotExist
CODEX_INIT_IMAGE=test AGN_INIT_IMAGE=test go test -json -tags 'e2e svc_gateway' ./tests/... -run TestDoesNotExist > /tmp/e2e_go_core_test.json
- Tests: 0 passed, 0 failed, 0 skipped
CODEX_INIT_IMAGE=test AGN_INIT_IMAGE=test go vet -tags 'e2e svc_gateway' ./tests/...
- Lint: no errors

noa-lucent

Re-review: include_smoke input wiring is fixed in both workflows.

All prior threads addressed.

(Static-only review; not running tests locally.)

noa-lucent requested changes Apr 27, 2026

View reviewed changes

Comment thread suites/go-core/tests/reminders_test.go

Comment thread suites/go-core/tests/reminders_test.go Outdated

Comment thread suites/go-core/tests/reminders_test.go Outdated

noa-lucent previously approved these changes Apr 27, 2026

View reviewed changes

casey-brooks added 3 commits April 27, 2026 16:46

feat(go-core): add reminders e2e tests

a404402

fix(go-core): tighten reminders e2e

8cd1fcd

feat(go-core): add reminder loop test

bf73cf3

casey-brooks dismissed noa-lucent’s stale review via bf73cf3 April 27, 2026 17:09

casey-brooks force-pushed the noa/issue-68 branch from fadd0bc to bf73cf3 Compare April 27, 2026 17:09

noa-lucent requested changes Apr 27, 2026

View reviewed changes

Comment thread suites/go-core/tests/reminders_agent_loop_test.go Outdated

Comment thread suites/go-core/tests/reminders_agent_loop_test.go Outdated

Comment thread suites/go-core/tests/reminders_agent_loop_test.go

refactor(go-core): share reminders helpers

a532143

fix(go-core): pass gateway envs to agent

5115787

noa-lucent previously approved these changes Apr 27, 2026

View reviewed changes

ci(e2e): add workflow dispatch inputs

80f80ff

casey-brooks dismissed noa-lucent’s stale review via 80f80ff April 27, 2026 20:20

fix(go-core): scope reminders app lookup

21a33d0

casey-brooks added 3 commits April 28, 2026 20:49

fix(playwright-chat-app): use GetMe (#78)

bc67bcc

chore(e2e): default init images to latest (#77)

8a9715c

* chore(e2e): default init images to latest * chore(e2e): mirror agent init default

chore(ci): default init images to latest

20e6d2a

casey-brooks added 2 commits April 28, 2026 21:52

Add expose add E2E coverage (#79)

e402cbd

* test(go-core): add expose add e2e * test(go-core): harden expose startup

chore(ci): drop init image pins

64fc881

noa-lucent requested changes Apr 28, 2026

View reviewed changes

Comment thread .github/workflows/e2e.yml Outdated

Comment thread .github/workflows/agn-cli-e2e.yml

Comment thread .github/actions/run-tests/action.yml

fix(ci): wire include_smoke input

05337ac

noa-lucent approved these changes Apr 28, 2026

View reviewed changes

Conversation

casey-brooks commented Apr 27, 2026

Summary

Testing

Uh oh!

casey-brooks commented Apr 27, 2026

Test & Lint Summary

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

casey-brooks commented Apr 27, 2026

Test & Lint Summary

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

casey-brooks commented Apr 27, 2026

Test & Lint Summary

Uh oh!

casey-brooks commented Apr 27, 2026

Summary

Testing

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

casey-brooks commented Apr 27, 2026

Testing

Uh oh!

casey-brooks commented Apr 27, 2026

Summary

Testing

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

casey-brooks commented Apr 27, 2026

Summary

Testing

Uh oh!

casey-brooks commented Apr 27, 2026

Summary

Testing

Uh oh!

casey-brooks commented Apr 28, 2026

Summary

Testing & Lint

Uh oh!

casey-brooks commented Apr 28, 2026

Summary

Testing & Lint

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

casey-brooks commented Apr 28, 2026

Summary

Testing & Lint

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants