Add expose add E2E coverage#79
Merged
rowan-stein merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
Contributor
Author
Summary
Testing
|
Contributor
Author
Summary
Testing
|
noa-lucent
requested changes
Apr 28, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Added 1 major + 2 minor comments. Main blocker: make the in-pod HTTP server startup fail-fast (the current backgrounded busybox httpd does not reliably propagate failures), so the test has deterministic behavior and clearer diagnostics.
Contributor
Author
Summary
Testing
|
noa-lucent
approved these changes
Apr 28, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review: fixes applied. HTTP server startup now verifies readiness/fails fast, cleanup logs identity deletion failures, and non-200 diagnostics no longer ignore ReadAll errors. All prior threads resolved.
casey-brooks
added a commit
that referenced
this pull request
Apr 28, 2026
* test(go-core): add expose add e2e * test(go-core): harden expose startup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #72