Skip to content

test(playwright): add workloads + threads smoke#85

Merged
rowan-stein merged 4 commits intomainfrom
noa/issue-84
May 1, 2026
Merged

test(playwright): add workloads + threads smoke#85
rowan-stein merged 4 commits intomainfrom
noa/issue-84

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • expand console Playwright suite tags for gateway/threads/identity selection
  • add a workloads layout smoke check with header bounding-box assertions
  • add threads list smoke coverage and retag the heavier threads test

Testing

  • npm ci (suites/playwright)
  • npx buf generate (suites/playwright)
  • npx tsc --noEmit (suites/playwright)
  • E2E_BASE_URL=https://console.agyn.dev npx playwright test --list (suites/playwright)

Ref #84

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm ci (suites/playwright)
  • npx buf generate (suites/playwright)
  • npx tsc --noEmit (suites/playwright)
  • E2E_BASE_URL=https://console.agyn.dev npx playwright test --list (suites/playwright)

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm ci (suites/playwright)
  • npx buf generate (suites/playwright)
  • npx tsc --noEmit (suites/playwright) - no errors
  • E2E_BASE_URL=https://console.agyn.dev npx playwright test --list (suites/playwright) - 36 tests listed (not executed)

noa-lucent
noa-lucent previously approved these changes May 1, 2026
Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds the requested smoke coverage for the bootstrap regressions in #84.

  • Suite selection update looks good: Playwright now runs for svc_gateway / svc_threads / svc_identity tags, and the grep logic remains OR/union.
  • New smoke tests cover (a) threads list loading and (b) workloads header grid layout.

Left a few minor suggestions inline (route alignment with the issue’s spec + bounding-box tolerance/locator robustness + explicit timeout on an async assertion).

Optional: if this PR is meant to close the issue, consider changing Ref #84Fixes #84.

Comment thread suites/playwright/test/e2e/workloads-layout.spec.ts Outdated
Comment thread suites/playwright/test/e2e/workloads-layout.spec.ts Outdated
Comment thread suites/playwright/test/e2e/organization-threads-smoke.spec.ts Outdated
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Update

  • switch workloads layout smoke to the org workloads route + stable header locators
  • wait for ListThreads + extend timeouts in the threads smoke assertions
  • loosen workloads header bbox tolerance to reduce flake

Test & Lint Summary

  • npx tsc --noEmit (suites/playwright)
  • E2E_BASE_URL=https://console.agyn.dev npx playwright test test/e2e/workloads-layout.spec.ts test/e2e/organization-threads-smoke.spec.ts (suites/playwright) failed: net::ERR_CONNECTION_REFUSED hitting https://console.agyn.dev/ in this environment (resolves to 127.0.0.1 here).

noa-lucent
noa-lucent previously approved these changes May 1, 2026
Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: updates address prior feedback.

  • Workloads layout test now exercises /organizations/:orgId/activity/workloads and uses more robust locators/tolerances.
  • Threads smoke test now waits for the list request and locates the matching row directly.

Approving.

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Update

  • wait for ListOrganizationThreads response before asserting rows
  • use Agent/Thread ID/Status headers with looser bbox tolerance

Test & Lint Summary

  • npx tsc --noEmit (suites/playwright)
  • E2E_BASE_URL=https://console.agyn.dev npx playwright test test/e2e/workloads-layout.spec.ts test/e2e/organization-threads-smoke.spec.ts (suites/playwright) failed: net::ERR_CONNECTION_REFUSED to https://console.agyn.dev/ in this environment (resolves to 127.0.0.1 here).

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Update

  • drop Thread ID button locator in workloads layout smoke (status/agent only)

Test & Lint Summary

  • npx tsc --noEmit (suites/playwright)
  • E2E_BASE_URL=https://console.agyn.dev npx playwright test test/e2e/workloads-layout.spec.ts test/e2e/organization-threads-smoke.spec.ts (suites/playwright) failed: net::ERR_CONNECTION_REFUSED to https://console.agyn.dev/ in this environment.

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review (new commits): changes look good.

  • Threads smoke now waits for the ListOrganizationThreads response and asserts HTTP 200 explicitly (clearer failure mode).
  • Workloads layout check switched to Status header + relaxed tolerances; still verifies multi-column layout (X separation) on the org workloads page.

No further changes requested.

@rowan-stein rowan-stein merged commit 7acc4cb into main May 1, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants