Conversation
Contributor
Author
Testing
|
Contributor
Author
Testing
|
Contributor
Author
Testing & Lint
|
noa-lucent
previously approved these changes
Apr 27, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good.
- App-proxy now dials the Ziti service by the dialable service name (
app-<slug>) instead of the internalziti_service_id. - ThreadsGateway: removes the duplicate
ListOrganizationThreadsdefinition and adds forwarding forGetUnackedMessageCounts. - Tests updated accordingly.
(Static-only review; not running tests locally.)
Contributor
Author
Summary
Testing & Lint
|
noa-lucent
previously approved these changes
Apr 27, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review after latest CI/env update.
- E2E workflow now pins init images via job env.
- App-proxy dial target remains
app-<slug>. - ThreadsGateway forwarding (
GetUnackedMessageCounts) still looks correct.
(Static-only review; not running tests locally.)
* fix(threads): drop duplicate method * fix(threads): add unacked counts * fix(ci): pin bootstrap ref * fix(ci): seed identity in e2e * fix(ci): update identity seed type * fix(ci): remove identity seed * chore(ci): set e2e init images * chore(ci): note e2e seed policy * fix(ci): register cluster admin identity * chore(ci): drop init image envs * fix(ci): restore init image envs * fix(ci): verify identity type * fix(ci): extend gateway startup wait * chore(e2e): simplify workflow steps
Contributor
Author
Summary
Testing & Lint
|
Contributor
Author
Summary
Testing & Lint
|
noa-lucent
approved these changes
Apr 28, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete.
- App-proxy now dials the correct Ziti service name (
app-<slug>). - ThreadsGateway no longer has a duplicate
ListOrganizationThreadsmethod and now forwardsGetUnackedMessageCounts. - DevSpace wait increased to 600s; error message matches.
(Static-only review; not running tests locally.)
noa-lucent
approved these changes
Apr 28, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review: still looks correct.
- App-proxy now derives the dial target as the dialable Ziti service name
app-<slug>. - ThreadsGateway forwards
GetUnackedMessageCountsand the duplicateListOrganizationThreadsis removed. - DevSpace health wait increase is consistent.
(Static-only review; not running tests locally.)
vitramir
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs: agynio/e2e#68