feat(identity): scaffold identity service

[casey-brooks]

Summary

• scaffold Identity gRPC service layout, migrations, and Helm chart
• implement identity store and server with identity type mapping
• add e2e test suite and CI/release workflows

Testing

• buf generate ../api --template buf.gen.yaml
• CGO_ENABLED=0 go test ./...
• CGO_ENABLED=0 go vet ./...
• CGO_ENABLED=0 go build ./...
• DOCKER_BUILDKIT=1 docker build -t identity-service-test --build-arg BUF_INPUT=https://github.com/agynio/api.git#branch=noa/issue-68 --build-arg BUF_PATH=proto/agynio/api/identity/v1 .

Issue

• #68

[casey-brooks]

Test & Lint Summary

• buf generate ../api --template buf.gen.yaml
• CGO_ENABLED=0 go test ./...
• CGO_ENABLED=0 go vet ./...
• CGO_ENABLED=0 go build ./...
• DOCKER_BUILDKIT=1 docker build -t identity-service-test --build-arg BUF_INPUT=https://github.com/agynio/api.git#branch=noa/issue-68 --build-arg BUF_PATH=proto/agynio/api/identity/v1 .

Tests: 0 passed, 0 failed, 0 skipped (go test ./...)
Lint: go vet (no issues)

[casey-brooks]

Test & Lint Summary

• buf generate ../api --template buf.gen.yaml
• CGO_ENABLED=0 go test ./...
• CGO_ENABLED=0 go vet ./...
• CGO_ENABLED=0 go build ./...

Tests: 0 passed, 0 failed, 0 skipped (go test ./...)
Lint: go vet (no issues)

[casey-brooks]

Summary

• align identity type mapping to updated enum numeric values
• update batch response usage to entries field

Test & Lint Summary

• buf generate ../api --template buf.gen.yaml
• CGO_ENABLED=0 go test ./...
• CGO_ENABLED=0 go vet ./...
• CGO_ENABLED=0 go build ./...

Tests: 0 passed, 0 failed, 0 skipped (go test ./...)
Lint: go vet (no issues)

[noa-lucent]

Clean scaffold overall — the service structure, boundary/internal separation, error handling, and Helm setup are solid. Two items need addressing before merge:

1. Magic numbers in converter — The proto↔DB int16 mapping uses raw literals in two separate switch statements. Extract named constants or a shared mapping table to prevent the two sides from drifting apart.
2. Missing unit tests for converter — This is the core correctness contract. Add a converter_test.go with round-trip and error-case coverage so mapping regressions are caught at build time without a database.

Minor/nit items (redundant parseUUID guard, unnecessary ORDER BY, CI missing go vet, DATABASE_URL comment) are noted inline but non-blocking.

[casey-brooks]

Summary

• centralize identity type DB/proto mapping with constants + shared table
• add converter unit tests and simplify parseUUID
• remove unnecessary ORDER BY, add go vet CI step, and clarify DATABASE_URL value

Test & Lint Summary

• buf generate ../api --template buf.gen.yaml
• CGO_ENABLED=0 go test ./...
• CGO_ENABLED=0 go vet ./...
• CGO_ENABLED=0 go build ./...

Tests: 1 passed, 0 failed, 0 skipped (go test ./...)
Lint: go vet (no issues)

[casey-brooks]

Test & Lint Summary (updated)

• buf generate ../api --template buf.gen.yaml
• CGO_ENABLED=0 go test ./...
• CGO_ENABLED=0 go vet ./...
• CGO_ENABLED=0 go build ./...

Tests: 4 passed, 0 failed, 0 skipped (go test ./...)
Lint: go vet (no issues)

[rowan-stein]

All 6 review comments addressed:

1. Magic numbers → Centralized into named constants with a shared mapping table.
2. Converter tests → Added converter_test.go with 4 unit tests.
3. Error path → Fixed identityTypeToProto return on error.
4. Redundant guard → Removed empty-string check in parseUUID.
5. CI vet → Added go vet step to CI workflow.
6. Nits → Removed ORDER BY from batch query; updated DATABASE_URL values.yaml comment.

CI is green (4 tests passing). Ready for re-review.

[noa-lucent]

All 6 prior comments verified and resolved against the actual code:

1. ✅ Magic numbers → Named constants + single identityTypeMappings slice drives both directions. Clean.
2. ✅ Default returns UNSPECIFIED → Now returns zero value on error path.
3. ✅ Redundant parseUUID guard → Removed; uuid.Parse handles all cases. fmt import cleaned up.
4. ✅ Missing unit tests → converter_test.go added with round-trip, UNSPECIFIED rejection, and unknown-value tests. Good coverage.
5. ✅ ORDER BY → Removed from batch query.
6. ✅ CI go vet → Step added.
7. ✅ DATABASE_URL comment → Comment added in values.yaml.

Looks good — clean service scaffold, solid boundary/internal separation, and the converter is now well-tested and maintainable. Ship it.