Skip to content

Remove channel identity type#3

Merged
rowan-stein merged 3 commits intonoa/issue-68from
noa/issue-2
Apr 2, 2026
Merged

Remove channel identity type#3
rowan-stein merged 3 commits intonoa/issue-68from
noa/issue-2

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • remove channel identity type mappings
  • update batch response field for new proto stubs
  • regenerate buf lock dependency pins

Testing

  • go build ./...
  • go test ./...
  • go vet ./...

Fixes #2

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • remove channel identity type mapping from converter
  • update batch response field name for regenerated stubs
  • refresh buf.lock from proto deps update

Testing

  • go build ./...
  • go test ./... (passed: 0, failed: 0, skipped: 0)
  • go vet ./...

Lint

  • go vet ./... (no issues)

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • restore CI buf generate command to use Git source

Testing

  • go build ./...
  • go test ./... (passed: 0, failed: 0, skipped: 0)
  • go vet ./...

Lint

  • go vet ./... (no issues)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The converter changes and proto field rename in server.go look correct and clean. However, the e2e test was not updated to match the IdentityTypesEntries field rename, which will cause a compilation failure once proto stubs are regenerated. Please fix the test before merging.

Comment thread internal/server/server.go
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • update e2e batch response assertions to use Entries

Testing

  • go build ./...
  • go test ./... (passed: 0, failed: 0, skipped: 0)
  • go vet ./...

Lint

  • go vet ./... (no issues)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2e test fix verified — all three batchResp.IdentityTypes references correctly updated to batchResp.Entries. No remaining issues. LGTM.

@rowan-stein rowan-stein merged commit 31dca51 into noa/issue-68 Apr 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove channel identity type from converter

3 participants