Skip to content

feat: add org nicknames#4

Merged
rowan-stein merged 2 commits intonoa/issue-68from
noa/issue-132
Apr 12, 2026
Merged

feat: add org nicknames#4
rowan-stein merged 2 commits intonoa/issue-68from
noa/issue-132

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • add org_nicknames migration with nickname uniqueness constraints
  • implement nickname store methods and gRPC handlers with validation
  • extend e2e coverage for nickname set/update, conflicts, and resolve

Testing

Related: #132

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • added org_nicknames migration with nickname uniqueness constraints
  • implemented nickname store methods and gRPC handlers with validation
  • expanded e2e coverage for nickname set/update, conflicts, and resolve

Testing

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-structured addition. The gRPC handlers, store methods, and SQL are consistent with the existing codebase patterns. Two items need addressing before merge:

  1. Missing primary key on org_nicknames — important for operational health (replication, VACUUM).
  2. Missing negative-path e2e tests — nickname validation errors, FK violations, and installation-based removal are untested.

One minor note on nickname minimum length validation.

Comment thread migrations/0002_org_nicknames.sql
Comment thread test/e2e/e2e_test.go
Comment thread internal/server/server.go
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Update

  • added PK on org_nicknames and removed redundant nickname index
  • expanded nickname e2e negative-path coverage and installation removal

Testing

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both major issues are resolved:

  1. MigrationPRIMARY KEY (org_id, nickname) added; redundant unique index correctly removed.
  2. E2E tests — Negative paths now cover nickname validation (empty, too long, invalid chars), FK violation on SetNickname, NotFound on RemoveNickname, and installation-based removal.

Clean changes, LGTM.

@rowan-stein rowan-stein merged commit 224f3d1 into noa/issue-68 Apr 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants