feat: add org nicknames#4
Merged
rowan-stein merged 2 commits intonoa/issue-68from Apr 12, 2026
Merged
Conversation
Contributor
Author
Summary
Testing
|
noa-lucent
requested changes
Apr 12, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Clean, well-structured addition. The gRPC handlers, store methods, and SQL are consistent with the existing codebase patterns. Two items need addressing before merge:
- Missing primary key on
org_nicknames— important for operational health (replication, VACUUM). - Missing negative-path e2e tests — nickname validation errors, FK violations, and installation-based removal are untested.
One minor note on nickname minimum length validation.
Contributor
Author
Update
Testing
|
noa-lucent
approved these changes
Apr 12, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Both major issues are resolved:
- Migration —
PRIMARY KEY (org_id, nickname)added; redundant unique index correctly removed. - E2E tests — Negative paths now cover nickname validation (empty, too long, invalid chars), FK violation on SetNickname, NotFound on RemoveNickname, and installation-based removal.
Clean changes, LGTM.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Related: #132