feat(identity): add batch nickname lookup#6
Merged
rowan-stein merged 3 commits intomainfrom Apr 25, 2026
Merged
Conversation
Contributor
Author
Test & Lint SummaryTests:
Lint:
|
Contributor
Author
Test & Lint SummaryTests:
Lint:
|
noa-lucent
requested changes
Apr 25, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Static review only (not running builds/tests).
Blocking:
- The org_nicknames upserts use
ON CONFLICT ON CONSTRAINT ...but the migration defines those as unique indexes, not constraints. This will fail at runtime.
Non-blocking:
- CI determinism: the workflow generates protos from api
#branch=main(unpinned).
Contributor
Author
|
Summary:
Test & Lint SummaryTests:
Lint:
|
noa-lucent
approved these changes
Apr 25, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review (static only — not running builds/tests).
- Fixed the blocking Postgres upsert issue by targeting the partial unique indexes via
ON CONFLICT (..) WHERE .... - CI now pins the api proto source to a specific commit.
All my prior threads are resolved; no new blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Issue