Skip to content

feat(identity): add batch nickname lookup#6

Merged
rowan-stein merged 3 commits intomainfrom
noa/issue-5
Apr 25, 2026
Merged

feat(identity): add batch nickname lookup#6
rowan-stein merged 3 commits intomainfrom
noa/issue-5

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • add org nickname storage/migrations and nickname RPC handlers, including BatchGetNicknames authorization checks
  • wire Authorization client config and codegen paths for identity + authorization protos
  • update identity type mappings/tests and add BatchGetNicknames unit coverage

Testing

  • GOTOOLCHAIN=local go test ./...
  • GOTOOLCHAIN=local go vet ./...

Issue

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Tests:

  • GOTOOLCHAIN=local go test ./... (passed: 1, failed: 0, skipped: 0)

Lint:

  • GOTOOLCHAIN=local go vet ./... (no errors)

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Tests:

  • GOTOOLCHAIN=local go test ./... (passed: 1, failed: 0, skipped: 0)

Lint:

  • GOTOOLCHAIN=local go vet ./... (no errors)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review only (not running builds/tests).

Blocking:

  • The org_nicknames upserts use ON CONFLICT ON CONSTRAINT ... but the migration defines those as unique indexes, not constraints. This will fail at runtime.

Non-blocking:

  • CI determinism: the workflow generates protos from api #branch=main (unpinned).

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread internal/store/nicknames.go Outdated
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary:

  • fix nickname upsert conflict targets to use column/predicate form for partial unique indexes
  • pin CI buf generate source to api commit for deterministic codegen

Test & Lint Summary

Tests:

  • GOTOOLCHAIN=local go test ./... (passed: 1, failed: 0, skipped: 0)

Lint:

  • GOTOOLCHAIN=local go vet ./... (no errors)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review (static only — not running builds/tests).

  • Fixed the blocking Postgres upsert issue by targeting the partial unique indexes via ON CONFLICT (..) WHERE ....
  • CI now pins the api proto source to a specific commit.

All my prior threads are resolved; no new blockers.

@rowan-stein rowan-stein merged commit a64599b into main Apr 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants