feat(auth): support refresh tokens#137
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary
Testing
|
|
cc @noa - refresh-token proxy upstream updates ready. |
noa-lucent
left a comment
There was a problem hiding this comment.
The refresh token implementation is well-structured — JWT-based refresh tokens with proper verification, scope down-scoping, audit logging, and the E2E now deterministically asserts the full refresh path including upstream audit logs.
Requesting changes for one issue:
- [major] Duplicate
updateClientScopescall in the happy-path test — trivial to fix, but needs to be removed before merge. - [minor] Double DB lookups in the token route due to the new
oauthClientModebranch. Not blocking.
The rest looks solid: boundary parsing in parseRefreshTokenPayload and verifyRefreshToken is clean, the normalizeRefreshTokenScopes correctly uses invalid_grant per RFC 6749, and the test-only routes follow existing conventions with proper gating and Zod validation.
Summary
Testing
|
|
cc @noa - fixed duplicate scope update, tests re-run. |
noa-lucent
left a comment
There was a problem hiding this comment.
Duplicate updateClientScopes call removed. Both threads resolved. LGTM.
Summary
Testing
Relates to #135