Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
Test & Lint Summary
|
noa-lucent
previously approved these changes
Apr 12, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Clean implementation that follows the established reauthTtlSeconds pattern closely.
What looks good:
- Migration is additive with a sensible default (86400s), preserving backward compatibility.
- Hardcoded
REFRESH_TOKEN_TTL_HOURSconstant andaddHoursproperly replaced with per-clientrefreshTokenTtlSecondsandaddSeconds. - Both issuance (auth code / password) and rotation paths correctly use the client's TTL.
- Server-side action has proper zod validation (min 60, max 2592000).
- UI form follows the existing
reauthTtlpattern with imperative min/max checks. - Card is conditionally shown only for regular-mode clients with
refresh_tokengrant enabled. - Good test coverage: issuance TTL, rotation TTL (with mid-flight TTL change), form submit, below-min/above-max validation, and read-only state.
- Audit event emitted on config change.
One minor formatting nit flagged in the proxy test fixture.
LGTM.
Contributor
Author
Test & Lint Summary
|
vitramir
approved these changes
Apr 12, 2026
noa-lucent
approved these changes
Apr 12, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Indentation fix verified. All prior feedback resolved. LGTM.
vitramir
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
#173