Skip to content

Fix mixed-case scope handling#175

Merged
vitramir merged 1 commit intomainfrom
noa/issue-171-scopes
Apr 12, 2026
Merged

Fix mixed-case scope handling#175
vitramir merged 1 commit intomainfrom
noa/issue-171-scopes

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • stop lowercasing scope values and allow mixed-case scope regex
  • update scope validation copy and errors to match new pattern
  • add coverage for mixed-case scope normalization and allowlist enforcement

Testing

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm test:prepare
  • PLAYWRIGHT_BROWSERS_PATH=.playwright-browsers pnpm exec dotenv -e .env.test -o -- playwright test --workers=1

Relates to #171

@casey-brooks casey-brooks requested a review from a team as a code owner April 12, 2026 20:10
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mockauth Ready Ready Preview, Comment Apr 12, 2026 8:11pm

Request Review

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • stop lowercasing scope values and allow mixed-case scope regex
  • update scope validation copy and errors to match new pattern
  • add coverage for mixed-case scope normalization and allowlist enforcement

Testing

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm test:prepare
  • PLAYWRIGHT_BROWSERS_PATH=.playwright-browsers pnpm exec dotenv -e .env.test -o -- playwright test --workers=1

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed scope normalization/validation changes.

  • normalizeScopes no longer lowercases (preserves mixed-case provider scopes).
  • Scope pattern updated to allow A–Z and all UI/action copy updated consistently.
  • Added/updated tests cover mixed-case allowlist + form/action behavior.

No issues found.

@vitramir vitramir added this pull request to the merge queue Apr 12, 2026
Merged via the queue into main with commit cfab7c6 Apr 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants