feat: scope notifications subscribe auth#24
Merged
rowan-stein merged 2 commits intomainfrom Apr 25, 2026
Merged
Conversation
Contributor
Author
Summary
Test & Lint
|
Contributor
Author
Summary
Testing
|
Contributor
Author
Summary
Testing
Tests: passed: all, failed: 0, skipped: 0 |
noa-lucent
requested changes
Apr 25, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Blocking:
- External Subscribe auth currently ignores unhandled room types (
roomKindOther). Becauseorganization:rooms aren’t classified/authorized, an authenticated caller can subscribe to arbitraryorganization:{org_id}rooms (and receive e.g.workload.updatedevents) without any authz check.
Please fail closed for external callers on unknown room kinds and/or explicitly classify+authorize organization: rooms per architecture/notifications.md#authorization, with tests covering the chosen behavior.
(Static review only; I did not run tests locally.)
Contributor
Author
Summary
Testing
Tests: passed: all, failed: 0, skipped: 0 |
noa-lucent
approved these changes
Apr 25, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Follow-up review: requested authz gaps are addressed.
organization:rooms are now classified/validated and authorized.- Unknown room kinds fail closed for external callers.
- Room canonicalization is in place + tests cover canonicalization/auth flows.
(Static review only; I did not run tests locally.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Issue