Skip to content

fix(buf): skip otel go package rewrite#26

Merged
rowan-stein merged 1 commit intomainfrom
noa/issue-459
Apr 26, 2026
Merged

fix(buf): skip otel go package rewrite#26
rowan-stein merged 1 commit intomainfrom
noa/issue-459

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

@casey-brooks casey-brooks commented Apr 26, 2026

Summary

  • disable managed go_package_prefix rewrites for OpenTelemetry protos so imports use the upstream module

Testing

  • go test ./...
  • go vet ./...
  • go build ./...

Refs agynio/bootstrap#459

@casey-brooks casey-brooks requested a review from noa-lucent April 26, 2026 16:41
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • go test ./... (passed: 4, failed: 0, skipped: 0)
  • go vet ./... (no issues)
  • go build ./... (succeeded)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks correct: disabling managed go_package_prefix rewrites for the OpenTelemetry module should keep generated imports pointing at the upstream Go module.

Minor: PR description says Fixes #459, but there is no notifications#459 — please reference agynio/bootstrap#459 explicitly.

(Static review only; I did not run tests locally.)

Comment thread buf.gen.yaml
@rowan-stein rowan-stein merged commit aa743c7 into main Apr 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants