Skip to content

fix(authz): use otlp trace import#27

Merged
rowan-stein merged 2 commits intomainfrom
noa/issue-459-authz
Apr 26, 2026
Merged

fix(authz): use otlp trace import#27
rowan-stein merged 2 commits intomainfrom
noa/issue-459-authz

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • switch trace proto import to upstream go.opentelemetry.io/proto/otlp/trace/v1

Testing

  • go test ./...
  • go vet ./...
  • go build ./...
  • docker buildx build --load -t notifications-test .

Refs agynio/bootstrap#459

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • go test ./... (passed: 4, failed: 0, skipped: 0)
  • go vet ./... (no issues)
  • go build ./... (succeeded)
  • docker buildx build --load -t notifications-test . (succeeded)

@casey-brooks casey-brooks requested a review from noa-lucent April 26, 2026 17:20
noa-lucent
noa-lucent previously approved these changes Apr 26, 2026
Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  • buf.gen.yaml disables managed go_package_prefix rewrites for the OpenTelemetry module, so generated code keeps upstream OTLP import paths.
  • authz.go now imports go.opentelemetry.io/proto/otlp/trace/v1, matching the generated tracingv1 bindings.

Minor follow-up: now that OTLP types are imported from upstream, we should be able to delete the committed shim internal/.gen/opentelemetry/proto/trace/v1/trace_alias.go and keep internal/.gen/ generated-only.

(Static review only; I did not run tests locally.)

Comment thread internal/server/authz.go
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate buf.build/agynio/api --template ./buf.gen.yaml
  • go test ./... (passed: 4, failed: 0, skipped: 0)
  • docker buildx build --load -t notifications-test . (succeeded)

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate buf.build/agynio/api --template ./buf.gen.yaml
  • go test ./... (passed: 4, failed: 0, skipped: 0)
  • go vet ./... (no issues)
  • docker buildx build --load -t notifications-test . (succeeded)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: looks good.

  • authz.go now imports OTLP trace types from go.opentelemetry.io/proto/otlp/trace/v1.
  • Committed shim internal/.gen/opentelemetry/.../trace_alias.go is removed (keeps internal/.gen/ generated-only).

(Static review only; I did not run tests locally.)

@rowan-stein rowan-stein merged commit d117dd9 into main Apr 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants