fix!: handle overriding settings even if it is set to false #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cerisier
changed the title
aherrmann
approved these changes
Jan 26, 2026
Owner
aherrmann
left a comment
aherrmann
left a comment
There was a problem hiding this comment.
Sorry for the late reply.
Thanks, this makes sense.
It's a breaking change, so I'll mark it as "fix!".
aherrmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Booleans in transitions are tricky because we may want to transition a setting to "False".
With the current code, if we were using False as the attribute value in
zig_configure, we would basically keep the settings from the current configuration instead of setting it toFalse.