Conversation
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
changed the title
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR targets reliability of the SQLite-backed storage by preventing FTS5 index corruption during deletes and by attempting to improve the user-facing error when opening the database fails.
Changes:
- Add a validation/error path when opening a builtin SQLite database.
- Fix FTS setup to avoid dropping a non-existent FTS table and include
rowidin the FTS5 delete trigger. - Document the fixes in
NEWS.orgas release0.6.2.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
triples.el |
Adds an extra error path intended to improve messaging when sqlite-open fails. |
triples-fts.el |
Fixes FTS table recreation behavior and corrects the delete trigger to include rowid. |
NEWS.org |
Adds a 0.6.2 changelog entry describing the fixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.