🔧 deps(mastra): fix js-yaml DoS alert (#36)#353
Merged
Conversation
Bumps the existing pnpm.overrides pin for the transitive js-yaml dependency from 4.2.0 to ^4.3.0, resolving Dependabot alert #36 (YAML merge-key chains can force quadratic CPU consumption / DoS).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js-yamlYAML merge-key chains can force quadratic CPU consumption (DoS), vulnerable range>=4.0.0,<4.3.0, patched at4.3.0.js-yamlis a transitive dependency innode/mastra(pulled in viagray-matter), already pinned through an existingpnpm.overridesentry at4.2.0. Bumped that override to^4.3.0.node/mastra/pnpm-lock.yamlviapnpm install; confirmed nojs-yamlversion in the vulnerable range remains in the lockfile.Why
Resolve the open Dependabot security alert without expanding
js-yamlto a direct dependency, per repo policy.Test plan
pnpm installinnode/mastraregenerates lockfile cleanly (onlyjs-yamlbumped to 4.3.0, plus incidentallibcmetadata churn from pnpm's resolver)pnpm run build(tsc --noEmit) passespnpm test(vitest) — 2 test files, 7 tests, all passinggrep js-yaml node/mastra/pnpm-lock.yamlshows only4.3.0Closes alert: https://github.com/ai-agent-assembly/examples/security/dependabot/36