🔧 Bump napi and napi-derive from 3.10.5/3.5.10 to 3.11.0/3.6.0 (synced)#322
Merged
Conversation
This was referenced Jul 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Combines dependabot #319 (napi-derive 3.5.10 -> 3.6.0) and #320 (napi 3.10.5 -> 3.11.0). Bumping either alone breaks the build: the napi attribute macro expansion references bindgen_prelude symbols (TypeTag, napi_type_tag, type_tag_from_ident, validate_type_tag) that only exist when both crates are on the same generation. Verified with `pnpm native:build` (napi-build's own toolchain, matching CI) and the full test suite (631 passing).
Chisanan232
force-pushed
the
fix/napi-sync-3.11
branch
from
July 22, 2026 03:34
b4bb745 to
d1eb3e5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines dependabot #319 (napi-derive 3.5.10 → 3.6.0) and #320 (napi 3.10.5 → 3.11.0).
Both crates must be upgraded together — bumping only one (as #319 and #320 each did individually) breaks the build:
The
#[napi]macro (from napi-derive) expands to reference bindgen_prelude symbols that only exist consistently when both crates are the same generation.Verified locally:
pnpm native:build(napi's own build tooling, same command CI'snapi-buildjob runs) succeeds, and the full test suite passes (631 tests, 2 pre-existing skips).Closes the need for #319 and #320 — closing those individually.