[AAASM-2959] 🔧 (release-python): Sync Cargo.lock in pin-ffi-to-tag.sh - #124
Merged
Chisanan232 merged 1 commit intoJun 15, 2026
Merged
Conversation
Contributor
Author
Claude Code review — AAASM-2959 (#123 follow-up: sync Cargo.lock in pin-ffi-to-tag.sh)CI stateGreen. Scope vs. acceptance criteria
Context: #123 (merged) added the pin rewrite but left the lock; this completes it so the manifest + lock agree and the build can be hardened with VerdictReady for approval and merge. Completes the build-time half of the lock-sync. — Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #123. The
pin-ffi-to-tag.shhelper rewrites theaa-core/aa-proto/aa-sdk-clientrevinnative/aa-ffi-python/Cargo.tomlbefore each maturin build, but left the siblingCargo.lockrecording the old rev. The wheel only built correctly because maturin doesn't run--locked(cargo silently re-resolves).This adds a
cargo update -p aa-core -p aa-proto -p aa-sdk-clientlock-sync at the end of the helper (guarded oncargo+ lockfile presence; the maturin build mounts the same checkout, so it uses the synced lock). Keeps the manifest and lock consistent and unblocks hardening the build with--lockedlater.Companion fixes in the same AAASM-2959 lock-sync sweep: open pin PRs #121 / #133 (lockfiles synced) and agent-assembly#1049 (bot pin-bump jobs now
cargo update).Type of Change
Breaking Changes
Related Issues
Testing
CI-script change;
bash -n+shellcheckclean. The lock-sync is verified by the samecargo updateflow already applied manually to #121/#133 (which moved the 3 git depsalpha.9→beta.1cleanly).Checklist