Optimize header layout performance with flexbox mixins - #5
Open
everettbu wants to merge 1 commit into
Open
Conversation
|
This pull request has been automatically marked as stale because it has been open for 60 days with no activity. To keep it open, remove the stale tag, push code, or add a comment. Otherwise, it will be closed in 14 days. |
mfeuerstein
reviewed
Apr 10, 2026
mfeuerstein
left a comment
mfeuerstein
left a comment
There was a problem hiding this comment.
PR Review — approved
Reviewed 5 files. 0 high-severity issues found. Verdict: approved.
app/assets/stylesheets/common/base/header.scss (low)
- Reviewed app/assets/stylesheets/common/base/header.scss — looks good
app/assets/stylesheets/common/foundation/mixins.scss (low)
- Reviewed app/assets/stylesheets/common/foundation/mixins.scss — looks good
app/assets/stylesheets/common/base/topic.scss (low)
- Reviewed app/assets/stylesheets/common/base/topic.scss — looks good
app/assets/stylesheets/common/components/badges.css.scss (low)
- Reviewed app/assets/stylesheets/common/components/badges.css.scss — looks good
app/assets/stylesheets/common/base/topic-post.scss (low)
- Reviewed app/assets/stylesheets/common/base/topic-post.scss — looks good
zach-source
approved these changes
Jul 31, 2026
zach-source
left a comment
zach-source
left a comment
There was a problem hiding this comment.
CSS-only diff converting header/topic layout to flexbox mixins. Found one concrete regression (a selector's only rule was deleted rather than migrated) and one design risk (float removed in favor of a flex-only positioning trick where the flex container isn't visibly established in this diff), plus a minor project-convention violation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test 5