Skip to content

fix: remove default-members in workspace#6279

Merged
nv-anants merged 8 commits intomainfrom
anants/remove-default-ws
Feb 18, 2026
Merged

fix: remove default-members in workspace#6279
nv-anants merged 8 commits intomainfrom
anants/remove-default-ws

Conversation

@nv-anants
Copy link
Copy Markdown
Member

@nv-anants nv-anants commented Feb 13, 2026

Overview:

Remove default-members from the Cargo workspace to eliminate the drift between default-members and members.

The default-members list was originally introduced to exclude packages (mainly dynamo-run) that are slow to build and are not shipped as flagship features.

Clippy fixes

lib/bindings/python/codegen/src/prometheus_parser.rs
unnecessary_unwrap: Replaced if is_macro_generated && macro_prefix.is_some() { let prefix = macro_prefix.as_ref().unwrap(); ... } with if is_macro_generated { if let Some(prefix) = macro_prefix.as_ref() { ... } }.

lib/kv-router/src/concurrent_radix_tree.rs
unnecessary_cast: Removed redundant as u64 in two places (lines 1142 and 1162) where the value was already u64.

lib/kv-router/src/indexer.rs
redundant_closure: Replaced all .map(|i| LocalBlockHash(i)) with .map(LocalBlockHash) (27 occurrences).
unnecessary_get_then_check: Replaced scores.scores.get(&WorkerWithDpRank::new(0, 0)).is_none() with !scores.scores.contains_key(&WorkerWithDpRank::new(0, 0)).

closes: OPS-3275

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated workspace configuration to include all members by default.
  • Refactor

    • Simplified conditional logic and code structure for improved maintainability.
  • Tests

    • Enhanced test implementations with improved type inference and assertion clarity.

Signed-off-by: Anant Sharma <anants@nvidia.com>
Signed-off-by: Anant Sharma <anants@nvidia.com>
Signed-off-by: Anant Sharma <anants@nvidia.com>
Signed-off-by: Anant Sharma <anants@nvidia.com>
@nv-anants nv-anants marked this pull request as ready for review February 18, 2026 15:18
@nv-anants nv-anants requested a review from a team as a code owner February 18, 2026 15:18
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 18, 2026

Walkthrough

This pull request removes the explicit default-members block from the Cargo workspace configuration, allowing the workspace to include all members by default. Simultaneously, it refactors conditional logic, simplifies type inference in test code across multiple crates, and adjusts assertion condition patterns in tests.

Changes

Cohort / File(s) Summary
Workspace Configuration
Cargo.toml
Removed explicit default-members block; workspace now defaults to including all members rather than selectively excluding crates.
Prometheus Parser Refactor
lib/bindings/python/codegen/src/prometheus_parser.rs
Refactored conditional logic for applying macro-generated prefixes using nested if-let pattern; functional behavior unchanged.
KV Router Test Updates
lib/kv-router/src/concurrent_radix_tree.rs, lib/kv-router/src/indexer.rs
Simplified type inference in test constructors by removing explicit numeric casts; refactored assertion conditions from is_none() checks to contains_key() pattern.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Members now dance where they're meant to be seen,
Conditionals nested in patterns pristine,
Type inference flows through the tests with such grace,
A workspace renewed in its rightful place! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing default-members from the workspace configuration, which is the primary modification in Cargo.toml.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check ✅ Passed The pull request description includes all required sections: Overview clearly states the main change (removing default-members), Details provides context about the original purpose and rationale for the change, and includes specific Clippy fixes with file locations. Related Issues section closes OPS-3275. The description is well-structured and complete.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@grahamking grahamking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping someone would do this :-)

@nv-anants nv-anants merged commit aa16ccf into main Feb 18, 2026
86 of 87 checks passed
@nv-anants nv-anants deleted the anants/remove-default-ws branch February 18, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants