fix: wire reasoning parser from worker runtime config into frontend#6300
fix: wire reasoning parser from worker runtime config into frontend#6300MatejKosec merged 1 commit intomainfrom
Conversation
WalkthroughA new public method Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8b14fb9 to
66e7f10
Compare
66e7f10 to
8732f07
Compare
8732f07 to
d28cc6f
Compare
d28cc6f to
641af6f
Compare
The frontend's get_parsing_options() hardcoded reasoning_parser to None, meaning reasoning content was never extracted from model output regardless of the worker's --dyn-reasoning-parser setting. Add get_model_reasoning_parser() following the same pattern as get_model_tool_call_parser() to read the parser name from the worker's RuntimeConfig via service discovery. Signed-off-by: Matej Kosec <mkosec@nvidia.com>
641af6f to
76a5ff2
Compare
…i-dynamo#6300) Signed-off-by: Matej Kosec <mkosec@nvidia.com> Signed-off-by: Trilok Sachin <ctsachin3@gmail.com>
Summary
get_parsing_options()inModelManagerhardcodedreasoning_parsertoNone(with a TODO comment), soreasoning_contentwas always null in API responses regardless of the worker's--dyn-reasoning-parsersetting.get_model_reasoning_parser()method (mirrors existingget_model_tool_call_parser()) that readsreasoning_parserfrom the worker'sRuntimeConfigvia service discovery.get_parsing_options()to call the new method instead of returningNone.Test plan
--dyn-reasoning-parser deepseek_r1reasoning_contentis populated in streaming responses via both OpenAI (/v1/chat/completions) and Anthropic (/v1/messages) endpointsSummary by CodeRabbit
New Features
Improvements