CI setupを共通actionに集約 - #120
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release-app.yml (1)
1-1: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winワークフロー全体の既定権限を読み取り専用に固定してください。
releaseジョブはcontents: writeを明示していますが、トップレベルのpermissionsがないため、他のジョブがリポジトリ既定権限を継承する可能性があります。トップレベルにcontents: readを追加し、releaseジョブの書き込み権限は維持してください。提案
name: Release App +permissions: + contents: read🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release-app.yml at line 1, Set the workflow-level default permissions to read-only by adding top-level contents: read near the workflow name, while preserving the release job’s explicit contents: write permission.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/release-app.yml:
- Line 1: Set the workflow-level default permissions to read-only by adding
top-level contents: read near the workflow name, while preserving the release
job’s explicit contents: write permission.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 0a0f3a4d-9df2-4056-955b-19c4b93ac137
📒 Files selected for processing (5)
.github/actions/setup/action.yml.github/workflows/maestro-release-smoke.yml.github/workflows/on-main-merge.yml.github/workflows/on-pull-request.yml.github/workflows/release-app.yml
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |



概要
CI の Java/Gradle setup 手順を composite action に集約し、release workflow のファイル名と表示名を整理します。
変更内容
.github/actions/setup/action.ymlを追加on-release.ymlをrelease-app.ymlにリネームRelease Appに変更検証
.github/actions/setup/action.yml,.github/workflows/*.yml対象git diff --check補足
actionlintが無いため未実施です。Summary by CodeRabbit