Fixes issue with get_avg_corr and count_solved_instances#5
Open
John-A-Aydin wants to merge 4 commits intoai4society:mainfrom
Open
Fixes issue with get_avg_corr and count_solved_instances#5John-A-Aydin wants to merge 4 commits intoai4society:mainfrom
get_avg_corr and count_solved_instances#5John-A-Aydin wants to merge 4 commits intoai4society:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed metacognition to never memorize solutions with
systemALL.Using
memorize_solutionwithsystemALLwas preventingget_avg_corrandcount_solved_instancesfrom looking at any instances of s1 and s2 solutions that were chosen by the metacognition module.These functions would only count instances where the user called metacognition with
run_type = "s1" | "s2".