Skip to content

🎨 Palette: Clean up dynamic terminal output via ANSI Erase in Line#111

Open
EiJackGH wants to merge 1 commit intomainfrom
palette/cli-erase-line-ux-18187167964531317196
Open

🎨 Palette: Clean up dynamic terminal output via ANSI Erase in Line#111
EiJackGH wants to merge 1 commit intomainfrom
palette/cli-erase-line-ux-18187167964531317196

Conversation

@EiJackGH
Copy link
Collaborator

  • 💡 What: Replaced the anti-pattern of hardcoded trailing spaces used to clear dynamic terminal output lines with the standard ANSI escape sequence \033[K (Erase in Line). This was updated in src/main.cpp for the countdown, "GO!" print, and the main game score output loop.
  • 🎯 Why: Dynamically updating CLI lines via carriage return (\r) requires clearing previous longer strings. Padding with spaces is fragile and messy, leaving visual artifacts if the new string length is significantly shorter. Using \033[K immediately clears the line cleanly and deterministically.
  • 📸 Before/After: No visual difference assuming the spaces were always perfectly long enough; however, under the hood, the UX is robust and artifact-free regardless of string length.
  • Accessibility/UX: Improves general visual interactions and ensures clean screen redraws in the CLI environment, reducing cognitive load from potential UI glitches. Recorded this learning in .Jules/palette.md.

PR created automatically by Jules for task 18187167964531317196 started by @EiJackGH

Replaced hardcoded padding spaces with the ANSI escape sequence `\033[K`
(Erase in Line) immediately following `\r` (carriage return). This
ensures dynamic terminal output clears trailing text properly, avoiding
visual artifacts when string lengths change, which leads to a cleaner UX.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant