Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Someone is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
mxmul
commented
Dec 6, 2024
| "main": "dist/index.js", | ||
| "module": "dist/index.mjs", | ||
| "browser": "dist/auto.global.js", | ||
| "browser": "dist/index.js", |
Author
There was a problem hiding this comment.
webpack prefers the browser field by default. When bundling, I think consumers will generally want the side-effect free module instead of auto.global.js.
RobPruzan
force-pushed
the
main
branch
2 times, most recently
from
7526d13 to
47c46ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using
react-scanin a project with a legacy webpack 4 build, and noticed that the NPM dist uses modern syntax that can't be parsed. To work around, I've been runningreact-scanthrough babel-loader, but this PR should fix the problem.It seems that webpack 4 uses acorn@6 to parse JS, and that it only supports es2018 syntax1. Changing the compilation target for
esnexttoes2018fixes the issue, and doesn't affect the build size too much (52kb -> 54kb).Tested with a trivial webpack 4 config:
Footnotes
https://github.com/acornjs/acorn/blob/6.x/acorn/README.md ↩