Skip to content

Change RPE default from 1 to 5 to avoid misleading "Nothing at all" on new entries#19

Merged
aidmax merged 1 commit into
mainfrom
claude/fix-rpe-default-0poMm
Apr 18, 2026
Merged

Change RPE default from 1 to 5 to avoid misleading "Nothing at all" on new entries#19
aidmax merged 1 commit into
mainfrom
claude/fix-rpe-default-0poMm

Conversation

@aidmax
Copy link
Copy Markdown
Owner

@aidmax aidmax commented Apr 18, 2026

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 18, 2026

Greptile Summary

This PR changes the default RPE value from 1 ("Nothing at all") to 5 ("Moderate") in getDefaultWorkoutValues() to prevent new entries from appearing to report no exertion. The hasData sentinel in the Core Metrics collapsible section and the test fixture defaultValues are updated in lockstep to reflect the new default.

Confidence Score: 5/5

Safe to merge — minimal, well-scoped change with no logic errors or regressions.

All three touch-points (default value, hasData sentinel, test fixture) are updated consistently. No P0 or P1 findings; the schema already accepts 5, form reset and draft restoration all behave correctly with the new default.

No files require special attention.

Important Files Changed

Filename Overview
client/src/pages/home.tsx Default RPE changed to 5 in getDefaultWorkoutValues() and hasData sentinel updated from !== 1 to !== 5 — both changes are consistent and correct.
client/src/test/hooks/use-form-persistence.test.ts Test fixture defaultValues.rpe updated from 1 to 5 to match new application default; no test logic is affected since no test asserts on the RPE field directly.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User opens app / clears form] --> B["getDefaultWorkoutValues()\nrpe: 5 ← NEW default"]
    B --> C[form.reset with defaults]
    C --> D{Has user changed RPE?}
    D -- "rpe === 5 (default)" --> E["hasData = false\n(no indicator shown)"]
    D -- "rpe ≠ 5 (user-modified)" --> F["hasData = true\n(indicator shown on Core Metrics)"]
    F --> G[Markdown preview includes R: value]
    E --> G
Loading

Reviews (1): Last reviewed commit: "Change RPE default from 1 to 5 to avoid ..." | Re-trigger Greptile

@aidmax aidmax merged commit 59302dc into main Apr 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants