Fix Windows CI Unicode crash; enumerate ontological issues in oe_ifm#27
Merged
aidoruao merged 2 commits intoFeb 20, 2026
Conversation
…d enumeration script and report Co-authored-by: aidoruao <174227749+aidoruao@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enumerate all ontological issues and errors
Fix Windows CI Unicode crash; enumerate ontological issues in oe_ifm
Feb 19, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical Windows CI failure caused by Unicode encoding issues and adds a comprehensive enumeration of ontological issues found in the OE-IFM module. The fix ensures cross-platform determinism by standardizing stdout encoding to UTF-8 across all platforms.
Changes:
- Added
PYTHONIOENCODING: utf-8environment variable to CI workflow to prevent Windows Unicode encoding errors - Created enumeration script that systematically scans code for ontological issues using the Orthogonal Engineering failure ontology framework
- Generated structured JSON report documenting 6 identified issues (1 resolved, 5 accepted)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/pr26-cross-platform.yml |
Added UTF-8 encoding environment variable to fix Windows CP1252 encoding crash |
enumerate_ontological_issues.py |
New script that enumerates ontological issues following the OE failure taxonomy |
ontology/pr26_ontological_issues.json |
Generated report documenting 6 issues with severity, status, and resolution details |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 3 Windows CI jobs (Python 3.10–3.12) crashed with
UnicodeEncodeErrorbefore any determinism test ran — ✓/✗ characters inprint()calls are unencodable in the default Windowscp1252codec.Changes
CI fix —
.github/workflows/pr26-cross-platform.ymlAdded
PYTHONIOENCODING: utf-8to the "Run determinism test" step so Python stdout uses UTF-8 on all platforms:Ontological issues enumeration —
enumerate_ontological_issues.pyNew script that scans the
oe_ifmmodule against the existing OE failure ontology (ontology/failure_ontology.yaml) and writes a structured report toontology/pr26_ontological_issues.json.6 issues enumerated:
print()without encoding guardGITHUB_OUTPUTwrite in text mode adds\r\non Windowsupdate_weights_sequential()defined but never calledsafetensorsint64 version dependency>=0.4.0already pinned)Script exits 1 if any issue remains
open, 0 otherwise.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.