Skip to content

Fix Windows CI Unicode crash; enumerate ontological issues in oe_ifm#27

Merged
aidoruao merged 2 commits into
copilot/remove-floating-arithmeticfrom
copilot/enumerate-ontological-issues
Feb 20, 2026
Merged

Fix Windows CI Unicode crash; enumerate ontological issues in oe_ifm#27
aidoruao merged 2 commits into
copilot/remove-floating-arithmeticfrom
copilot/enumerate-ontological-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 19, 2026

All 3 Windows CI jobs (Python 3.10–3.12) crashed with UnicodeEncodeError before any determinism test ran — ✓/✗ characters in print() calls are unencodable in the default Windows cp1252 codec.

Changes

CI fix — .github/workflows/pr26-cross-platform.yml

Added PYTHONIOENCODING: utf-8 to the "Run determinism test" step so Python stdout uses UTF-8 on all platforms:

env:
  PYTHONHASHSEED: 0
  PYTHONIOENCODING: utf-8   # ← added; prevents cp1252 UnicodeEncodeError on Windows

Ontological issues enumeration — enumerate_ontological_issues.py

New script that scans the oe_ifm module against the existing OE failure ontology (ontology/failure_ontology.yaml) and writes a structured report to ontology/pr26_ontological_issues.json.

6 issues enumerated:

ID Severity Issue Status
OE-PR26-001 high Unicode chars in print() without encoding guard resolved
OE-PR26-002 medium Integer projection weight update is a no-op placeholder known limitation
OE-PR26-003 low Hard little-endian requirement undocumented as platform boundary accepted
OE-PR26-004 low GITHUB_OUTPUT write in text mode adds \r\n on Windows accepted
OE-PR26-005 low update_weights_sequential() defined but never called accepted
OE-PR26-006 low safetensors int64 version dependency accepted (>=0.4.0 already pinned)

Script exits 1 if any issue remains open, 0 otherwise.

Original prompt

Pull Request: https://github.com/aidoruao/orthogonal-engineering/pull/26/files

enumerate all ontological issues and errors


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…d enumeration script and report

Co-authored-by: aidoruao <174227749+aidoruao@users.noreply.github.com>
Copilot AI changed the title [WIP] Enumerate all ontological issues and errors Fix Windows CI Unicode crash; enumerate ontological issues in oe_ifm Feb 19, 2026
Copilot AI requested a review from aidoruao February 19, 2026 22:56
@aidoruao aidoruao requested review from Copilot and removed request for aidoruao February 20, 2026 00:48
@aidoruao aidoruao marked this pull request as ready for review February 20, 2026 00:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical Windows CI failure caused by Unicode encoding issues and adds a comprehensive enumeration of ontological issues found in the OE-IFM module. The fix ensures cross-platform determinism by standardizing stdout encoding to UTF-8 across all platforms.

Changes:

  • Added PYTHONIOENCODING: utf-8 environment variable to CI workflow to prevent Windows Unicode encoding errors
  • Created enumeration script that systematically scans code for ontological issues using the Orthogonal Engineering failure ontology framework
  • Generated structured JSON report documenting 6 identified issues (1 resolved, 5 accepted)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/pr26-cross-platform.yml Added UTF-8 encoding environment variable to fix Windows CP1252 encoding crash
enumerate_ontological_issues.py New script that enumerates ontological issues following the OE failure taxonomy
ontology/pr26_ontological_issues.json Generated report documenting 6 issues with severity, status, and resolution details

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants