PR #36: Fix onboarding validation bugs and add meta-platform schema#36
Merged
Conversation
Co-authored-by: aidoruao <174227749+aidoruao@users.noreply.github.com>
Co-authored-by: aidoruao <174227749+aidoruao@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Integrate Meta-Platform with Yeshua schema
PR #36: Fix onboarding validation bugs and add meta-platform schema
Feb 22, 2026
This was referenced Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four pre-existing test failures in
test_onboarding_check.pycaused by mismatched thresholds, incomplete regex patterns, and unsafe dataclass serialization. Also addspr36_schema.py— the PR #36 meta-platform integration schema following the establishedpr35_schema.pypattern.Bug fixes in
toolkit/oe/onboarding_check.pyvalidate_artifact_structureclassified artifacts with 4 missing fields (out of 7 required) as"invalid"instead of"partial". Changed<= 3→<= 4."Directories scanned: 10"format was not matched. Addedr"directories?\s+scanned[:\s]+\d+"todir_patterns.identify_candidate_artifactsusedre.match(anchored), so"full_onboarding.md"was missed. Addedr".*onboard.*\.(md|txt|json|yaml|yml)$"to catch "onboard" anywhere in the filename.asdict()on non-dataclasses:save_stage_outputscalleddataclasses.asdict()unconditionally on list items, crashing on plain strings/dicts. Addedis_dataclass()guard before callingasdict().New:
pr36_schema.py+tests/test_pr36_schema.pyImplements the 7-section PR #36 schema (same structure as
pr35_schema.py):60 tests cover all sections; all pass.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.