security: patch desktop updater js-yaml parser#36
Draft
aiis2 wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #34 tracks one high and one moderate js-yaml advisory on the production dependency path:
Current release artifacts keep updater publishing disabled, so the path is latent today. Retaining the affected parser would make the risk immediately relevant when publishing is enabled. electron-updater already accepts
js-yaml@^4.1.0, so replacing only the compatible shared lock node is narrower than upgrading electron-updater, adding a direct dependency, or introducing a workspace override.Specification: #35
Verification
114c62a: package-anchored resolution reached js-yaml 4.1.1 and failed only below the 4.3.0 floor2c3525b: the unchanged contract resolved js-yaml 4.3.0 and passedPending Integration Gates
Closes #34