qa(connectors): gate unauthenticated /api/connectors/* routes + harden env write#45
Merged
Conversation
…en env write - Add gateBoard() to the four global /api/connectors/* routes (setup-status, setup, enable-managed, catalog) that previously ran with no auth while every sibling credential route is board-gated. setup persists COMPOSIO_API_KEY to .env and enable-managed flips managed billing, so these were unauthenticated state mutations. - Reject CR/LF in the setup apiKey body and in writeOrUpdateEnvFile values to prevent newline-injection of extra .env lines. - Write .env with mode 0o600 (was default umask) since it may hold a plaintext Composio key. - Document WAVEX_COMPOSIO_MANAGED and WAVEX_CORE_URL in .env.example and clarify that WAVEX_COMPOSIO_DISABLED=0 is inert until COMPOSIO_API_KEY is set. - De-drift stale op-omega/op-omega-server references in plugin doc comments to wavex-os-server (the live route path is already /wavex-os/...; comments only). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qa(connectors): gate unauthenticated
/api/connectors/*routes + harden env write + docsSmallest-safe fixes from a full triage of the connector suite (composio-shim, credential vault, connect/marketplace routes, plugin UI). 9 surfaces audited, 28 findings logged; this PR ships only the safe, verified subset.
Fixes
gateBoard()to the four global/api/connectors/*routes (setup-status,setup,enable-managed,catalog) — they ran with no auth while every sibling credential route is board-gated.setuppersistsCOMPOSIO_API_KEYto.envandenable-managedflips managed billing, so these were unauthenticated state mutations.credentials.tssetupapiKeybody and inwriteOrUpdateEnvFilevalues — prevents newline-injection of extra.envlines.credentials.ts.envwithmode 0o600(was default umask) — it may hold a plaintext Composio key.credentials.tsWAVEX_COMPOSIO_MANAGED+WAVEX_CORE_URL; clarifyWAVEX_COMPOSIO_DISABLED=0is inert until a key is set..env.exampleop-omega/op-omega-serverreferences in plugin doc comments (live route path was already/wavex-os/...; comments only).ConnectorsSidebar.tsx,worker.ts4 files, +41/-10.
Verification
wavex-os-servertypecheck: exit 0 with these changes.composio-shimtests: 12/12 pass (no regression).credentials.ts:264/337/352/369/585/605; the four fixed routes previously did not.Notable findings NOT fixed here (need a decision or live access)
featured-toolkits.ts:28-30slugsgoogle_calendar/google_drive/microsoft_calendarlikely don't match Composio's canonical slugs (googlecalendar/googledrive; nomicrosoft_calendar) → live OAuth dead-paths. Not changed — needs live-account verification; slugs double as vault/UI keys.initiateandmarketplaceroutes lack per-company auth (IDOR) — needs a route-auth-shape decision.process.envmutation / key-write-window / un-keyed hashHint / 403-vs-500 mapping, C09 missing route-auth tests.Full per-finding detail (file:line + proposed fix) in the run deliverables under
.plateau-agency/deliverables/connectors/.🤖 Generated with Claude Code