Conversation
There was a problem hiding this comment.
Pull request overview
Updates the ad-hoc GHCR build workflow to default to building linux/amd64 images (per Berlin’s current needs) while keeping the target platform configurable for future multi-arch builds.
Changes:
- Adds a
workflow_dispatchinput (platforms) with a default oflinux/amd64. - Wires the Docker build step to use the provided
platformsinput (with an amd64 fallback).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with: | ||
| context: . | ||
| platforms: linux/amd64,linux/arm64 | ||
| platforms: ${{ github.event.inputs.platforms || 'linux/amd64' }} |
There was a problem hiding this comment.
This workflow uses github.event.inputs.platforms to read the workflow_dispatch input, but other workflows in this repo consistently use the inputs context (e.g., manual-build.yaml). For consistency and readability, consider switching to ${{ inputs.platforms }} here; since you already define a default on the input, the || 'linux/amd64' fallback can likely be removed as well.
Suggested change
| platforms: ${{ github.event.inputs.platforms || 'linux/amd64' }} | |
| platforms: ${{ inputs.platforms }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to https://github.com/aimtheory/quantifai-deploy/issues/7\n\nBerlin only needs amd64, so default the ad hoc GHCR workflow to linux/amd64 and keep platforms configurable for future multi-arch builds.