[PR #11737/f30f43e6 backport][3.13] Skip benchmarks in ci when running in fork repositories#11990
Conversation
Forks cannot use codspeed account, which can make benchmark job in ci fail if aiohttp contributors want to run test workflow on their forks. This pr make unnecessary steps skip if triggered workflow is not in the main repository. aiohttp contributors can now run github action workflows to test changes in their forks without unnecessary errors. Co-authored-by: 🇺🇦 Sviatoslav Sydorenko <webknjaz@redhat.com> (cherry picked from commit f30f43e)
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
|
@rodrigobnogueira you shouldn't need to push commits to restart CI jobs. You should be able to go to the respective job and click restart right in the GH UI. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.13 #11990 +/- ##
==========================================
+ Coverage 98.03% 98.27% +0.24%
==========================================
Files 128 128
Lines 44508 44508
Branches 2421 2421
==========================================
+ Hits 43633 43742 +109
+ Misses 689 590 -99
+ Partials 186 176 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Admins only, I believe. |
Not exactly. I know for a fact that I'm able to do this in repos where I don't have admin access. But I did forget that triagers don't have write access, indeed: Tip Who can use this feature? 👤 People with write permissions to a repository can re-run workflows in the repository. (https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs) |
…n running in fork repositories (aio-libs#11990) Co-authored-by: Rui Xi <Cycloctane@outlook.com> Co-authored-by: 🇺🇦 Sviatoslav Sydorenko <webknjaz@redhat.com> Co-authored-by: rodrigo.nogueira <rodrigo.nogueira@prf.gov.br>
Description
What do these changes do?
This is a backport of PR #11737 to the
3.13branch.Forks cannot use codspeed account, which can make benchmark job in ci fail if aiohttp contributors want to run test workflow on their forks. This change makes unnecessary steps skip if the triggered workflow is not in the main repository.
Are there changes in behavior for the user?
aiohttp contributors can now run github action workflows to test changes in their forks without unnecessary errors.
Is it a substantial burden for the maintainers to support this?
No, this is a straightforward CI configuration change.
Related issue number
Backport of #11737
Checklist
CONTRIBUTORS.txtCHANGES/folder