Skip to content

[PR #11737/f30f43e6 backport][3.13] Skip benchmarks in ci when running in fork repositories#11990

Merged
Dreamsorcerer merged 2 commits intoaio-libs:3.13from
rodrigobnogueira:backport/11737-to-3.13
Jan 24, 2026
Merged

[PR #11737/f30f43e6 backport][3.13] Skip benchmarks in ci when running in fork repositories#11990
Dreamsorcerer merged 2 commits intoaio-libs:3.13from
rodrigobnogueira:backport/11737-to-3.13

Conversation

@rodrigobnogueira
Copy link
Copy Markdown
Member

Description

What do these changes do?

This is a backport of PR #11737 to the 3.13 branch.

Forks cannot use codspeed account, which can make benchmark job in ci fail if aiohttp contributors want to run test workflow on their forks. This change makes unnecessary steps skip if the triggered workflow is not in the main repository.

Are there changes in behavior for the user?

aiohttp contributors can now run github action workflows to test changes in their forks without unnecessary errors.

Is it a substantial burden for the maintainers to support this?

No, this is a straightforward CI configuration change.

Related issue number

Backport of #11737

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES/ folder

Forks cannot use codspeed account, which can make benchmark job in ci
fail if aiohttp contributors want to run test workflow on their forks.
This pr make unnecessary steps skip if triggered workflow is not in the
main repository.

aiohttp contributors can now run github action workflows to test changes
in their forks without unnecessary errors.

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko <webknjaz@redhat.com>
(cherry picked from commit f30f43e)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 24, 2026
@rodrigobnogueira rodrigobnogueira changed the base branch from master to 3.13 January 24, 2026 02:50
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 24, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing rodrigobnogueira:backport/11737-to-3.13 (d2f1817) with 3.13 (e03822d)

Summary

✅ 59 untouched benchmarks

@webknjaz
Copy link
Copy Markdown
Member

@rodrigobnogueira you shouldn't need to push commits to restart CI jobs. You should be able to go to the respective job and click restart right in the GH UI.

@webknjaz webknjaz changed the title Backport/11737 to 3.13 [PR #11737/f30f43e6 backport][3.13] Backport/11737 to 3.13 Jan 24, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.27%. Comparing base (e03822d) to head (d2f1817).
⚠️ Report is 1 commits behind head on 3.13.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.13   #11990      +/-   ##
==========================================
+ Coverage   98.03%   98.27%   +0.24%     
==========================================
  Files         128      128              
  Lines       44508    44508              
  Branches     2421     2421              
==========================================
+ Hits        43633    43742     +109     
+ Misses        689      590      -99     
+ Partials      186      176      -10     
Flag Coverage Δ
CI-GHA 98.16% <ø> (+0.23%) ⬆️
OS-Linux 97.91% <ø> (+<0.01%) ⬆️
OS-Windows 95.64% <ø> (?)
OS-macOS 97.17% <ø> (+0.64%) ⬆️
Py-3.10.11 96.70% <ø> (+0.24%) ⬆️
Py-3.10.19 97.19% <ø> (?)
Py-3.11.14 97.39% <ø> (?)
Py-3.11.9 96.89% <ø> (?)
Py-3.12.10 96.98% <ø> (?)
Py-3.12.12 97.47% <ø> (?)
Py-3.13.11 97.70% <ø> (+0.36%) ⬆️
Py-3.14.2 97.64% <ø> (?)
Py-3.14.2t 96.75% <ø> (+0.01%) ⬆️
Py-3.9.13 96.60% <ø> (+0.24%) ⬆️
Py-3.9.25 97.08% <ø> (+0.65%) ⬆️
Py-pypy3.11.13-7.3.20 96.91% <ø> (+<0.01%) ⬆️
VM-macos 97.17% <ø> (+0.64%) ⬆️
VM-ubuntu 97.91% <ø> (+<0.01%) ⬆️
VM-windows 95.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webknjaz webknjaz changed the title [PR #11737/f30f43e6 backport][3.13] Backport/11737 to 3.13 [PR #11737/f30f43e6 backport][3.13] Skip benchmarks in ci when running in fork repositories Jan 24, 2026
@Dreamsorcerer
Copy link
Copy Markdown
Member

@rodrigobnogueira you shouldn't need to push commits to restart CI jobs. You should be able to go to the respective job and click restart right in the GH UI.

Admins only, I believe.

@Dreamsorcerer Dreamsorcerer merged commit 4a6936d into aio-libs:3.13 Jan 24, 2026
79 of 112 checks passed
@webknjaz
Copy link
Copy Markdown
Member

Admins only, I believe.

Not exactly. I know for a fact that I'm able to do this in repos where I don't have admin access.

But I did forget that triagers don't have write access, indeed:

Tip

Who can use this feature?

👤 People with write permissions to a repository can re-run workflows in the repository.

(https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs)

wavebyrd pushed a commit to wavebyrd/aiohttp that referenced this pull request Mar 13, 2026
…n running in fork repositories (aio-libs#11990)

Co-authored-by: Rui Xi <Cycloctane@outlook.com>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko <webknjaz@redhat.com>
Co-authored-by: rodrigo.nogueira <rodrigo.nogueira@prf.gov.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants