Fix spurious "Future exception was never retrieved" warning on disconnect during backpressure#12307
Open
availov wants to merge 5 commits intoaio-libs:masterfrom
Open
Fix spurious "Future exception was never retrieved" warning on disconnect during backpressure#12307availov wants to merge 5 commits intoaio-libs:masterfrom
availov wants to merge 5 commits intoaio-libs:masterfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12307 +/- ##
==========================================
- Coverage 99.11% 99.10% -0.01%
==========================================
Files 130 130
Lines 45558 45589 +31
Branches 2404 2405 +1
==========================================
+ Hits 45156 45183 +27
- Misses 272 275 +3
- Partials 130 131 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Dreamsorcerer
added
the
backport-3.14
…nect during backpressure
…nect during back-pressure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In
BaseProtocol._drain_helper()we replacedawait asyncio.shield(waiter)with plainawait waiter.Since each connection is handled by a single task, the shield didn't provide any benefit and prevented proper cancellation of the waiter future.
Now the future is cancelled cleanly and no spurious warning is logged.
Are there changes in behavior for the user?
No.
Is it a substantial burden for the maintainers to support this?
No, this is a very small and localized change.
Related issue number
Fixes #12281